Debian Bug report logs - #898836
HTML validator error for templates/popup: Stray end tag "span".

Display info messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Martin Michlmayr <tbm@cyrius.com>

To: submit@bugs.debian.org

Subject: HTML validator error for templates/popup: Stray end tag "span".

Date: Wed, 16 May 2018 12:43:57 +0200

Package: ikiwiki
Version: 3.20170111

While doc/templates/popup.mdwn has 4 opening <span> and 4 closing
</span> elements, the generated HTML has 3 opening and 4 closing
statements:

/usr/share/doc/ikiwiki/html/templates/popup.html
<p>[[templatebody &lt;&lt;TMPL_VAR mouseover&gt;
<span class="paren">[</span><span class="balloon">&lt;TMPL_VAR popup&gt;</span><span class="paren">]</span>
</span>
ENDBODY]]</p>

This leads to:

ERROR:html5validator.validator:"file:/home/tbm/scratch/cvs/spi/html/templates/popup/index.html":81.1-81.7: error: Stray end tag "span".

-- 
Martin Michlmayr
https://www.cyrius.com/

Message #10 received at 898836@bugs.debian.org (full text, mbox, reply):

From: Simon McVittie <smcv@debian.org>

To: Martin Michlmayr <tbm@cyrius.com>, 898836@bugs.debian.org

Subject: Re: Bug#898836: HTML validator error for templates/popup: Stray end tag "span".

Date: Wed, 16 May 2018 13:01:08 +0100

On Wed, 16 May 2018 at 12:43:57 +0200, Martin Michlmayr wrote:
> While doc/templates/popup.mdwn has 4 opening <span> and 4 closing
> </span> elements, the generated HTML has 3 opening and 4 closing
> statements:
> 
> /usr/share/doc/ikiwiki/html/templates/popup.html
> <p>[[templatebody &lt;&lt;TMPL_VAR mouseover&gt;
> <span class="paren">[</span><span class="balloon">&lt;TMPL_VAR popup&gt;</span><span class="paren">]</span>
> </span>
> ENDBODY]]</p>

That content isn't really meant to be rendered at all. If you change
[[templatebody to [[!templatebody in the source, does that resolve this?

    smcv

Message #15 received at 898836@bugs.debian.org (full text, mbox, reply):

From: Martin Michlmayr <tbm@cyrius.com>

To: Simon McVittie <smcv@debian.org>

Cc: 898836@bugs.debian.org

Subject: Re: Bug#898836: HTML validator error for templates/popup: Stray end tag "span".

Date: Wed, 16 May 2018 14:07:23 +0200

* Simon McVittie <smcv@debian.org> [2018-05-16 13:01]:
> That content isn't really meant to be rendered at all.

Right, but the problem is when I run "ikiwiki -v --plugin goodstuff website html"
then I end up with html/templates/popup/index.html (even though I
don't use any popups).  Therefore, running a HTML validator over my
whole html directory breaks.

> If you change [[templatebody to [[!templatebody in the source, does
> that resolve this?

I don't know.  I'll have to try later.
-- 
Martin Michlmayr
https://www.cyrius.com/

Message #20 received at 898836@bugs.debian.org (full text, mbox, reply):

From: Simon McVittie <smcv@debian.org>

To: Martin Michlmayr <tbm@cyrius.com>

Cc: 898836@bugs.debian.org

Subject: Re: Bug#898836: HTML validator error for templates/popup: Stray end tag "span".

Date: Wed, 16 May 2018 15:36:51 +0100

Control: tags -1 + patch fixed-upstream

On Wed, 16 May 2018 at 14:07:23 +0200, Martin Michlmayr wrote:
> * Simon McVittie <smcv@debian.org> [2018-05-16 13:01]:
> > That content isn't really meant to be rendered at all.
> 
> Right, but the problem is when I run "ikiwiki -v --plugin goodstuff website html"
> then I end up with html/templates/popup/index.html (even though I
> don't use any popups).

html/templates/popup/index.html is meant to be rendered, but it isn't
meant to include the body of the template reinterpreted as (bad) Markdown,
only the documentation of the template. (Compare templates/note, which
doesn't render an empty notebox in its HTML form.)

> > If you change [[templatebody to [[!templatebody in the source, does
> > that resolve this?
> 
> I don't know.  I'll have to try later.

It looks as though it does, so I pushed that change upstream.

    smcv

Message #27 received at 898836@bugs.debian.org (full text, mbox, reply):

From: Martin Michlmayr <tbm@cyrius.com>

To: Simon McVittie <smcv@debian.org>

Cc: 898836@bugs.debian.org

Subject: Re: Bug#898836: HTML validator error for templates/popup: Stray end tag "span".

Date: Thu, 17 May 2018 12:47:53 +0200

* Simon McVittie <smcv@debian.org> [2018-05-16 15:36]:
> It looks as though it does, so I pushed that change upstream.

Thank you!

-- 
Martin Michlmayr
https://www.cyrius.com/

Message #32 received at 898836-close@bugs.debian.org (full text, mbox, reply):

From: Simon McVittie <smcv@debian.org>

To: 898836-close@bugs.debian.org

Subject: Bug#898836: fixed in ikiwiki 3.20190207-1

Date: Thu, 07 Feb 2019 12:04:49 +0000

Source: ikiwiki
Source-Version: 3.20190207-1

We believe that the bug you reported is fixed in the latest version of
ikiwiki, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 898836@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Simon McVittie <smcv@debian.org> (supplier of updated ikiwiki package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Thu, 07 Feb 2019 11:13:08 +0000
Source: ikiwiki
Architecture: source
Version: 3.20190207-1
Distribution: unstable
Urgency: medium
Maintainer: Simon McVittie <smcv@debian.org>
Changed-By: Simon McVittie <smcv@debian.org>
Closes: 898836
Changes:
 ikiwiki (3.20190207-1) unstable; urgency=medium
 .
   [ Simon McVittie ]
   * New upstream release
     - Hide popup template content from documentation (Closes: #898836)
 .
   [ Ondřej Nový ]
   * d/changelog: Remove trailing whitespaces
 .
   [ Jelmer Vernooij ]
   * Allow Breezy as alternative to Bazaar.
Checksums-Sha1:
 7e67df036063cce703365063c3d5bad0bedb97be 2522 ikiwiki_3.20190207-1.dsc
 3caa33eebec59eca406159b9862eae8f5cb77aa6 2668840 ikiwiki_3.20190207.orig.tar.xz
 545e3c6ea1d819593d3d79ccbda6d2663261498b 86380 ikiwiki_3.20190207-1.debian.tar.xz
 2d5e77ad528fdd1b4951db068028816a319d9194 4988 ikiwiki_3.20190207-1_source.buildinfo
Checksums-Sha256:
 662788e6160081678c9db6c6656e5c1bc15675f72dc2651a8b2602d0b861284f 2522 ikiwiki_3.20190207-1.dsc
 3a5e4682a813998eddd5c6fced28679df3f6a441c4060352751c8968f55d574c 2668840 ikiwiki_3.20190207.orig.tar.xz
 5ae49532f2a9551b3a212bceadf0ca5afcee97b9466e5b8c14139565c077f007 86380 ikiwiki_3.20190207-1.debian.tar.xz
 e6d3e0877b5974bbf12e8153f296f6846c3ec04328d44dd802376728b7a13fce 4988 ikiwiki_3.20190207-1_source.buildinfo
Files:
 32645ab7f01da4795e0b209ba80ec05b 2522 web optional ikiwiki_3.20190207-1.dsc
 8a5c6b8030b59518599f5e67bcbcee71 2668840 web optional ikiwiki_3.20190207.orig.tar.xz
 79ffa8de4f8e4fef1da8fd60a58252c9 86380 web optional ikiwiki_3.20190207-1.debian.tar.xz
 eacb30f3be60223eee32edca364845ac 4988 web optional ikiwiki_3.20190207-1_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEENuxaZEik9e95vv6Y4FrhR4+BTE8FAlxcGQwACgkQ4FrhR4+B
TE8UHBAAqJERU7ndAas6so/5Hka/YQPtFtaCINw1pm5/JZrl4vxKuFYNX6y9uv3J
0Hf/RAWiaQOPcJwBBc6WcxBVJHbPsk8ga7a2+PnhlAf8HRi4c62pB15qEPO4eiwC
PLfkQog1NKo9Qhb1zz8ADAdm6I8LjQMJFSA8xyjco67kq5znSmtRZJq6b37Z5uIq
FlvR+SyUaOE2QKj+UM/LHnh7DR88Z6VWH//mmwlEKx+V+5RBfr7WfIgClAgCaLW2
t+kXHN1OjeWwfBY6hMZr0xzLvaNdUQqAxRfsAgi94ON3Xz5nfsF/9KReLKrkQa6F
TPuneT66fqzF1CK9ad45RbDaerrloxe1f+fbQmnUKH3fcRAPi7epZu82aaRKf4Y0
XZxEg0h+bvIqjNOPoFj7UBncioETI1Xixuf8IcwTiZzfPev7s9f1ZNAM2JmdOwOY
/02bGDUQ9fcTyu33Q3XOBXOecu/7XWkxFkiLdSAxOCKtR8Y4HENlSJN8jnqqMqwR
wtVQfGlnwz6ejoZo0i9Cs7CuIjxr8L3O1RjlrAQ1TlVvCybeL0PnOcl2dgKc99E5
Nwz0zO9kLtYzlelQ6NXJnnEL20wa+s3ARZCdzBT3a19PqDaIQvGckY94SPWu6f3L
jbGo0Lc/ig5oZmkOdNOk1tmLziO5UNVx0701ilugJnfVYF/OOtA=
=n3gd
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.