Changeset 286776 in webkit


Ignore:
Timestamp:
Dec 9, 2021, 6:03:45 AM (3 years ago)
Author:
Manuel Rego Casasnovas
Message:

[selectors] Match :focus-visible on <select> elements
​https://bugs.webkit.org/show_bug.cgi?id=233924

Reviewed by Antti Koivisto.

Source/WebCore:

Test: fast/forms/select-listbox-focusring.html

  • dom/Element.cpp:

(WebCore::shouldAlwaysHaveFocusVisibleWhenFocused):

LayoutTests:

  • fast/forms/select-listbox-focusring-expected.html: Added.
  • fast/forms/select-listbox-focusring.html: Added.
Location:
trunk
Files:
2 added
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r286763 r286776  
     12021-12-09  Manuel Rego Casasnovas  <rego@igalia.com>
     2
     3        [selectors] Match :focus-visible on <select> elements
     4        https://bugs.webkit.org/show_bug.cgi?id=233924
     5
     6        Reviewed by Antti Koivisto.
     7
     8        * fast/forms/select-listbox-focusring-expected.html: Added.
     9        * fast/forms/select-listbox-focusring.html: Added.
     10
    1112021-12-08  Patrick Griffis  <pgriffis@igalia.com>
    212

  • trunk/Source/WebCore/ChangeLog

    r286775 r286776  
     12021-12-09  Manuel Rego Casasnovas  <rego@igalia.com>
     2
     3        [selectors] Match :focus-visible on <select> elements
     4        https://bugs.webkit.org/show_bug.cgi?id=233924
     5
     6        Reviewed by Antti Koivisto.
     7
     8        Test: fast/forms/select-listbox-focusring.html
     9
     10        * dom/Element.cpp:
     11        (WebCore::shouldAlwaysHaveFocusVisibleWhenFocused):
     12
    1132021-12-09  Antti Koivisto  <antti@apple.com>
    214

  • trunk/Source/WebCore/dom/Element.cpp

    r286542 r286776  
    808808static bool shouldAlwaysHaveFocusVisibleWhenFocused(const Element& element)
    809809{
    810     return element.isTextField() || element.isContentEditable();
     810    return element.isTextField() || element.isContentEditable() || is<HTMLSelectElement>(element);
    811811}
    812812
Note: See TracChangeset for help on using the changeset viewer.