WIP: Bug 1703961 - Part 3: Implement custom highlights as Selection. r=emilio
AbandonedPublicDraft
Actions

Authored by jjaschke on Nov 24 2022, 5:22 PM.

Details

Reviewers: None
Bugzilla Bug ID: 1703961

Summary

This is done by adding a new entry SelectionType::eHighlight.
In contrast to the existing selection types, highlight selections can occur more than once
and are identified by their highlightName (i.e., ::highlight(foo) in css).
This made some changes necessary to nsFrameSelection,
which now uses an additional hash map of highlight selections,
as well as to several methods dealing with getting style properties for selected text
in nsTextFrame, which now in addition to the SelectionType enum need the highlight name
as well.

Depends on D163008

Diff Detail

Repository

rMOZILLACENTRAL mozilla-central

Branch

default

Lint

No Lint Coverage

Severity	Location	Code	Message
Error	dom/base/Highlight.cpp:75	mozilla-can-run-script	Build Error
Error	dom/base/Highlight.cpp:76	mozilla-can-run-script	Build Error
Error	dom/base/HighlightRegistry.cpp:53	mozilla-must-return-from-caller	Build Error
Error	dom/base/HighlightRegistry.cpp:72	mozilla-must-return-from-caller	Build Error
Error	layout/generic/nsFrameSelection.cpp:1590	mozilla-no-auto-type	Build Error
Error	layout/generic/nsFrameSelection.h:45	source-test-mozlint-file-whitespace	file-whitespace (Mozlint)
Warning	dom/base/AbstractRange.h:116	invalid-styling	clang-format
Warning	dom/base/Highlight.cpp:57	invalid-styling	clang-format
Warning	dom/base/HighlightRegistry.cpp:38	invalid-styling	clang-format
Warning	dom/base/HighlightRegistry.h:61	invalid-styling	clang-format
Warning	layout/generic/nsFrameSelection.h:45	invalid-styling	clang-format

Unit

No Test Coverage

Event Timeline

jjaschke planned changes to this revision.Nov 24 2022, 5:22 PM

jjaschke created this revision.

Herald added a project: secure-revision. · View Herald TranscriptNov 24 2022, 5:22 PM

Harbormaster completed remote builds in B482492: Diff 651243.Nov 24 2022, 5:22 PM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".Nov 24 2022, 5:22 PM

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: secure-revision.

Code analysis found 11 defects in the diff 651243:

1 defect found by file-whitespace (Mozlint)
5 build errors found by clang-tidy
5 defects found by clang-format

WARNING: Found 5 issues (warning level) that can be dismissed.

IMPORTANT: Found 6 issues (error level) that must be fixed before landing.

You can run this analysis locally with:

./mach clang-format -p dom/base/AbstractRange.h dom/base/HighlightRegistry.cpp layout/generic/nsFrameSelection.h dom/base/Highlight.cpp dom/base/HighlightRegistry.h
./mach lint --warnings --outgoing
./mach static-analysis check --outgoing (C/C++)

For your convenience, here is a patch that fixes all the clang-format defects (use it in your repository with hg import or git apply -p0).

If you see a problem in this automated review, please report it here.

You can view these defects in the Diff Detail section of Phabricator diff 651243.

Abandoned, See Bug 1803355.