Paths

Table of Contentst

Differential D191486

Bug 1860136: Fix up check for subject/non-subject match in relative selector invalidation. r=emilio
ClosedPublic
Actions

Authored by dshin on Oct 19 2023, 8:43 PM.

Tags

Referenced Files

	Unknown Object (File)
	Sun, Jun 30, 4:58 PM

	Unknown Object (File)
	Wed, Jun 19, 2:12 AM

	Unknown Object (File)
	Jun 14 2024, 6:32 PM

	Unknown Object (File)
	Jun 11 2024, 5:28 AM

	Unknown Object (File)
	Jun 7 2024, 6:38 AM

	Unknown Object (File)
	Jun 7 2024, 4:40 AM

	Unknown Object (File)
	Jun 6 2024, 11:46 PM

	Unknown Object (File)
	Jun 4 2024, 7:41 AM

View All 38 Files

Subscribers

Details

Reviewers

Commits

rMOZILLACENTRALd02d47db8d23: Bug 1860136: Fix up check for subject/non-subject match in relative selector…

Bugzilla Bug ID

Diff Detail

Repository

rMOZILLACENTRAL mozilla-central

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Build Status

Buildable 590139
Build 688224: arc lint + arc unit

Event Timeline

dshin created this revision.Oct 19 2023, 8:43 PM

Herald added a project: secure-revision. · View Herald TranscriptOct 19 2023, 8:43 PM

Harbormaster completed remote builds in B589336: Diff 777892.Oct 19 2023, 8:43 PM

phab-bot published this revision for review.Oct 19 2023, 8:43 PM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: secure-revision.

Herald added a subscriber: zrhoffman. · View Herald TranscriptOct 19 2023, 8:43 PM

emilio accepted this revision.Oct 20 2023, 10:08 AM

emilio added a project: testing-approved.

emilio added inline comments.

servo/components/style/invalidation/element/relative_selector.rs
557–573	You can bail out early if `!outer_dependency.selector.has_pseudo_element()`
561	Might be cleaner as: if let Component::Combinator(c) = c { if !c.is_pseudo_element() { return false; } }

This revision is now accepted and ready to land.Oct 20 2023, 10:08 AM

Code review changes

Harbormaster completed remote builds in B589505: Diff 778072.Oct 20 2023, 1:12 PM

Closed by commit rMOZILLACENTRALd02d47db8d23: Bug 1860136: Fix up check for subject/non-subject match in relative selector… (authored by dshin). · Explain WhyOct 23 2023, 1:15 PM

This revision was automatically updated to reflect the committed changes.

dshin added a commit: rMOZILLACENTRALd02d47db8d23: Bug 1860136: Fix up check for subject/non-subject match in relative selector….

Harbormaster completed remote builds in B590139: Diff 778487.Nov 23 2023, 5:30 PM

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

servo/

components/

style/

invalidation/

element/

relative_selector.rs

32 lines

94%

Loading...

testing/

web-platform/

tests/

css/

selectors/

invalidation/

has-pseudo-element.html

30 lines

-

-

Diff 778487

servo/components/style/invalidation/element/relative_selector.rs

Loading...

testing/web-platform/tests/css/selectors/invalidation/has-pseudo-element.html

Loading...