Page MenuHomePhabricator
Differential D192129

Bug 1861730 - Remove transition prefixes from nightly too. r=zcorpan,#layout
ClosedPublic
Actions

Authored by emilio on Oct 28 2023, 3:49 PM.

Details

Reviewers
zcorpan
jwatt
Commits
rMOZILLACENTRALffdf085e5e3c: Bug 1861730 - Remove transition prefixes from nightly too. r=jwatt
rMOZILLACENTRALb403bb5b1c83: Bug 1861730 - Remove transition prefixes from nightly too. r=jwatt
Bugzilla Bug ID
1861730
Summary

Code like the one from comment 7 seems reasonable. Let's try to disable
prefixed transitions along with prefixed transforms in order to minimize
the compat fallout from CSS zoom.

While I was at it I also fixed the prefixed animation entries in the
property database and crashtests. But those aliases remain enabled.

Diff Detail

Repository
rMOZILLACENTRAL mozilla-central
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emilio created this revision.Oct 28 2023, 3:49 PM
Herald added a project: secure-revision. · View Herald TranscriptOct 28 2023, 3:49 PM
Herald added a reviewer: necko-reviewers. · View Herald Transcript
Herald added a subscriber: boris. · View Herald Transcript
Harbormaster completed remote builds in B591826: Diff 780839.Oct 28 2023, 3:49 PM
phab-bot published this revision for review.Oct 28 2023, 3:49 PM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
Herald added subscribers: zrhoffman, masayuki, Itiel, mayhemer. · View Herald TranscriptOct 28 2023, 3:49 PM
emilio retitled this revision from Bug 1855763 - Remove transition prefixes from nightly too. r=zcorpan,#layout to Bug 1861730 - Remove transition prefixes from nightly too. r=zcorpan,#layout.Oct 29 2023, 3:32 PM
emilio changed the Bugzilla Bug ID from 1855763 to 1861730.
kershaw removed a reviewer: necko-reviewers.Oct 30 2023, 8:52 AM
emilio updated this revision to Diff 787044.Nov 15 2023, 9:40 AM

Rebase

Harbormaster completed remote builds in B596974: Diff 787044.Nov 15 2023, 9:40 AM
jwatt accepted this revision as: jwatt.Nov 18 2023, 6:24 PM
jwatt removed a reviewer: layout-reviewers.
jwatt added a project: testing-approved.
jwatt added a subscriber: jwatt.

Initially trying this in Nightly seems fine.

This revision is now accepted and ready to land.Nov 18 2023, 6:24 PM
Closed by commit rMOZILLACENTRALb403bb5b1c83: Bug 1861730 - Remove transition prefixes from nightly too. r=jwatt (authored by emilio). · Explain WhyNov 19 2023, 11:13 AM
This revision was automatically updated to reflect the committed changes.
emilio added a commit: rMOZILLACENTRALb403bb5b1c83: Bug 1861730 - Remove transition prefixes from nightly too. r=jwatt.
ctuns reopened this revision.Nov 19 2023, 12:07 PM
This revision is now accepted and ready to land.Nov 19 2023, 12:07 PM
ctuns added a reverting change: rMOZILLACENTRAL92e4e21ef642: Backed out changeset b403bb5b1c83 (bug 1861730) for causing mochitest failures….Nov 19 2023, 12:07 PM
emilio updated this revision to Diff 788562.Nov 20 2023, 12:36 PM

Minor fixup of property_database.js

Harbormaster completed remote builds in B598290: Diff 788562.Nov 20 2023, 12:36 PM
Closed by commit rMOZILLACENTRALffdf085e5e3c: Bug 1861730 - Remove transition prefixes from nightly too. r=jwatt (authored by emilio). · Explain WhyNov 20 2023, 12:41 PM
This revision was automatically updated to reflect the committed changes.
emilio added a commit: rMOZILLACENTRALffdf085e5e3c: Bug 1861730 - Remove transition prefixes from nightly too. r=jwatt.

Revision Contents
Changeset List

PathSize
dom/
animation/
test/
crashtests/
2 lines
editor/
libeditor/
tests/
6 lines
gfx/
tests/
crashtests/
4 lines
6 lines
reftest/
2 lines
layout/
base/
crashtests/
2 lines
4 lines
2 lines
generic/
crashtests/
2 lines
4 lines
4 lines
inspector/
tests/
4 lines
reftests/
svg/
smil/
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
style/
crashtests/
4 lines
2 lines
2 lines
2 lines
test/
262 lines
8 lines
modules/
libpref/
init/
2 lines
netwerk/
test/
crashtests/
4 lines

Diff 788565

View Options

dom/animation/test/crashtests/1714421.html

Loading...
View Options

editor/libeditor/tests/test_bug520189.html

Loading...
View Options

gfx/tests/crashtests/798853.html

Loading...
View Options

gfx/tests/crashtests/815489.html

Loading...
View Options

gfx/tests/reftest/611498-1.html

Loading...
View Options

layout/base/crashtests/668579.html

Loading...
View Options

layout/base/crashtests/813372-1.html

Loading...
View Options

layout/base/crashtests/840480.html

Loading...
View Options

layout/generic/crashtests/750066.html

Loading...
View Options

layout/generic/crashtests/767765.html

Loading...
View Options

layout/generic/crashtests/850931.html

Loading...
View Options

layout/inspector/tests/test_bug877690.html

Loading...
View Options

layout/reftests/svg/smil/smil-transitions-interaction-1a.svg

Loading...
View Options

layout/reftests/svg/smil/smil-transitions-interaction-1b.svg

Loading...
View Options

layout/reftests/svg/smil/smil-transitions-interaction-2a.svg

Loading...
View Options

layout/reftests/svg/smil/smil-transitions-interaction-2b.svg

Loading...
View Options

layout/reftests/svg/smil/smil-transitions-interaction-3a.svg

Loading...
View Options

layout/reftests/svg/smil/smil-transitions-interaction-3b.svg

Loading...
View Options

layout/reftests/svg/smil/smil-transitions-interaction-4a.svg

Loading...
View Options

layout/reftests/svg/smil/smil-transitions-interaction-4b.svg

Loading...
View Options

layout/style/crashtests/592698-1.html

Loading...
View Options

layout/style/crashtests/696188-1.html

Loading...
View Options

layout/style/crashtests/696869-1.html

Loading...
View Options

layout/style/crashtests/822766-1.html

Loading...
View Options

layout/style/test/property_database.js

Loading...
View Options

layout/style/test/test_garbage_at_end_of_declarations.html

Loading...
View Options

modules/libpref/init/StaticPrefList.yaml

Loading...
View Options

netwerk/test/crashtests/785753-1.html

Loading...
Privacy · Cookies · Legal