Marcos Caceres [:marcosc] Reporter
	Description • 7 years ago

PaymentAddress gained a `regionCode` attribute.

	Marcos Caceres [:marcosc] Reporter
	Comment 1 • 7 years ago

Assigning to Eden, but we are still working out the details in the spec (https://github.com/w3c/payment-request/pull/690). We also need to work out how we would actually support this, and if we should buy the data from ISO (or use Google's libaddressinput library). 

For the MVP, we are only supporting US and Canada, so it might be ok to just start with the regions of those two countries and go from there.

	Marcos Caceres [:marcosc] Reporter
	Comment 2 • 6 years ago

Gonna add the DOM side, which will just take the string (e.g., "CA" for California). I'm not sure we will do any validation in the DOM code yet.

	Marion Daly [:mdaly]
	Comment 3 • 6 years ago

P2: Assigned and actively worked on.

	Marco Mucci [:MarcoM]
	Comment 4 • 6 years ago

For assigned bugs being actively worked on we put the priority at P1.

	Marcos Caceres [:marcosc] Reporter
	Comment 5 • 6 years ago

Sorry, I got derailed by a different bug 😢 I’ll came back to this soon and set the priority appropriately when I do.

	Marcos Caceres [:marcosc] Reporter
	Comment 8 • 6 years ago

Thanks for picking this up, Eden.

	Eden Chuang[:edenchuang] Assignee
	Comment 9 • 6 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=eef4e3a5000c50a1d82525ad9ea01e6309fa367e

tryserver run for ensuring there is no regression fail.

	Eden Chuang[:edenchuang] Assignee
	Comment 10 • 6 years ago

rebase the patch.

	Eden Chuang[:edenchuang] Assignee
	Comment 11 • 6 years ago

rebase the patch

	Pulsebot
	Comment 12 • 6 years ago

Pushed by nbeleuzu@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a5a84cd8b79e
Adding an new attribute regionCode in PaymentAddress. r=baku
https://hg.mozilla.org/integration/mozilla-inbound/rev/37f53e939f61
mochitest for PaymentAddress.regionCode. r=baku

	Eliza Balazs [:ebalazs_]
	Comment 13 • 6 years ago

Backed out 2 changesets (Bug 1441752) for mochitest failures in dom/payments/test/test_basiccarderrors.html CLOSED TREE

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&resultStatus=testfailed,busted,exception,usercancel,runnable&revision=37f53e939f61efa9b11d4b4f8f3f1d36b065d79a&selectedJob=203397396

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=203397396&repo=mozilla-inbound&lineNumber=8885

Backout push: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&resultStatus=testfailed,busted,exception,usercancel,runnable&selectedJob=203397396&revision=3841f4ced817a06344835a744cefdf11667add7c

	Eden Chuang[:edenchuang] Assignee
	Comment 14 • 6 years ago

Fix the fail on BasiccardError tests.

	Marcos Caceres [:marcosc] Reporter
	Comment 15 • 6 years ago

Comment on attachment 9014425 [details] [diff] [review]
mochitest for regionCode attribute. r=baku

Review of attachment 9014425 [details] [diff] [review]:
-----------------------------------------------------------------

I wonder if region shoube be “California”, indtead of CA?

	Eden Chuang[:edenchuang] Assignee
	Comment 16 • 6 years ago

tryserver result.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d55f1a912b5c5ddcef3e589daad494b0759d0d1b&selectedJob=203415057

(In reply to Marcos Caceres [:marcosc] from comment #15)
> Comment on attachment 9014425 [details] [diff] [review]
> mochitest for regionCode attribute. r=baku
> 
> Review of attachment 9014425 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> I wonder if region shoube be “California”, indtead of CA?

I guess so, but here we do not restrict it to be.

	Marcos Caceres [:marcosc] Reporter
	Comment 17 • 6 years ago

(In reply to Eden Chuang[:edenchuang] from comment #16)
> I guess so, but here we do not restrict it to be.

Correct - it's more so just to distinguish them. We can always go back later and make those changes.

	Pulsebot
	Comment 18 • 6 years ago

Pushed by cbrindusan@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c29045d23143
Adding an new attribute regionCode in PaymentAddress. r=baku
https://hg.mozilla.org/integration/mozilla-inbound/rev/db490391893f
mochitest for PaymentAddress.regionCode. r=baku

	Stefan Hindli [:stefan_hindli]
	Comment 19 • 6 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/c29045d23143
https://hg.mozilla.org/mozilla-central/rev/db490391893f

	Hani Yacoub, Desktop QA
	Comment 20 • 6 years ago

regionCode is displayed empty in the received response whether I type CA or California in "State" field.

I'm not sure if the expected result is different than what I am verifying or what the expected behavior should be here.

	Eden Chuang[:edenchuang] Assignee
	Comment 21 • 6 years ago

This bug only provides the regionCode attribute in PaymentResponse and PaymentAddress.

I didn't implement the auto-generation of "regionCode" from "region".
That's why you get the empty "regionCode" in PaymentResponse.

We need a follow bug or reopen this bug for UI code implementation.

	Hani Yacoub, Desktop QA
	Comment 22 • 6 years ago

So should I log a bug for that?

	Eric Shepherd [:sheppy]
	Comment 23 • 6 years ago

Already documented. I added a mention to Firefox 64 for developers, though, and will have a PR submitted shortly that updates BCD for this.

	Matthew N. [:MattN]
	Comment 24 • 6 years ago

No Web Payment stuff should be in Firefox NN for developers where NN isn't Nightly as the feature isn't riding the trains so you can't even pref it on for Fx64 if you want to.

	Eric Shepherd [:sheppy]
	Comment 25 • 6 years ago

Yep, already fixed. I zoned on that one. :)