Home Assistant layouts are broken with :has selector enabled
Categories
(Core :: CSS Parsing and Computation, defect)
Tracking
()
People
(Reporter: dholbert, Unassigned)
References
()
Details
Attachments
(2 files)
STR:
- Toggle about:config pref
layout.css.has-selector.enabled
totrue
- Visit https://demo.home-assistant.io/ in a browser window that's as wide as possible (at least 1000px wide, to get the layout with several columns of widgets)
ACTUAL RESULTS:
Broken layout; various components are awkwardly squashed/overlapping.
EXPECTED RESULTS:
Functional layout.
Notes:
- this doesn't reproduce 100% of the time -- there's some sort of race condition involved -- but it's pretty reliable that I can trigger it within a few reloads, if not immediately. I haven't been able to reproduce it when I have the pref disabled.
- If I open devtools inspector, then that usually fixes the bug immediately (i.e. the layout changes suddenly). In some cases I need to hover elements in the inspector's DOM view. So presumably this is an invalidation bug of some sort, and devtools Inspector forces some invalidation that gets us the expected result.
- This may very well be a manifestation of some existing bug; I know dshin's working on various has-invalidation related things at the moment.
Reporter | ||
Comment 1•1 year ago
|
||
Reporter | ||
Comment 2•1 year ago
|
||
Reporter | ||
Comment 3•1 year ago
|
||
(This reproduces on my own local raspberry-pi-hosted Home Assistant instance, too.)
Reporter | ||
Updated•1 year ago
|
Reporter | ||
Comment 4•1 year ago
|
||
[ni=dshin to take a look when cycles are available, at least before enabling the about:config pref on Nightly. Maybe/hopefully this is just a version of a known issue & can be duped if so.]
Comment 5•1 year ago
|
||
This reminds me of bug 1843019 weirdness. hmm.
Comment 6•1 year ago
|
||
Ok, maybe not that - Could be just that the card being added before/after any other restyle triggers. Since :has doesn't invalidate, it can't restyle on its own.
.column:has(> *) {
flex-grow: 1;
}
Comment 7•1 year ago
|
||
It's not broken under 10+ reloads on local changeset for bug 1792501 on opt build, so pretty confident that this is a subset of invalidation.
(As an aside - Seems like :has(> *)
is being used for something like :-moz-only-whitespace
, which should eventually be identical to :empty
).
Reporter | ||
Comment 8•11 months ago
|
||
Verified dupe of bug 1792501.
I tested with Nightly before vs. after that bug landed (2023-09-14 vs 2023-09-15), with layout.css.has-selector.enabled
set totrue
. Broken in the "before" build, working in the "after" build.
Description
•