Closed Bug 1852965 Opened 11 months ago Closed 11 months ago

:has inner selector invalidation

Categories

(Core :: CSS Parsing and Computation, defect)

Product:
Core
Component:
CSS Parsing and Computation
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
120 Branch
Tracking Flags:
Tracking Status
firefox120 --- fixed

People

(Reporter: dshin, Assigned: dshin)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1852965: `:has` invalidation for inner selectors. r=emilio,#layout-reviewers
48 bytes, text/x-phabricator-request
Details | Review

i.e. `:has(:is(...), :not(...)), etc.

Severity: -- → S3
Blocks: has-pseudo
Assignee: nobody → dshin
Status: NEW → ASSIGNED
See Also: → 1853701
Blocks: 1855690
Pushed by dshin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7e07f570bd03
`:has` invalidation for inner selectors. r=emilio

Backed out for causing geckoview failures.

[task 2023-09-28T15:24:29.172Z] 15:24:29     INFO -  09-28 15:24:27.895 D/GeckoViewContent( 3451): handleEvent: DOMWindowClose
[task 2023-09-28T15:24:29.172Z] 15:24:29     INFO -  09-28 15:24:27.896 E/GeckoSessionTestRule( 3451): Error
[task 2023-09-28T15:24:29.173Z] 15:24:29     INFO -  09-28 15:24:27.896 E/GeckoSessionTestRule( 3451): org.mozilla.geckoview.test.rule.GeckoSessionTestRule$ChildCrashedException: Child process crashed
[task 2023-09-28T15:24:29.173Z] 15:24:29     INFO -  09-28 15:24:27.896 E/GeckoSessionTestRule( 3451): 	at org.mozilla.geckoview.test.rule.GeckoSessionTestRule$1.invoke(GeckoSessionTestRule.java:1226)
[task 2023-09-28T15:24:29.173Z] 15:24:29     INFO -  09-28 15:24:27.896 E/GeckoSessionTestRule( 3451): 	at java.lang.reflect.Proxy.invoke(Proxy.java:813)
[task 2023-09-28T15:24:29.173Z] 15:24:29     INFO -  09-28 15:24:27.896 E/GeckoSessionTestRule( 3451): 	at $Proxy22.onCrash(Unknown Source)
[task 2023-09-28T15:24:29.173Z] 15:24:29     INFO -  09-28 15:24:27.896 E/GeckoSessionTestRule( 3451): 	at org.mozilla.geckoview.GeckoSession$3.handleMessage(GeckoSession.java:542)
[task 2023-09-28T15:24:29.173Z] 15:24:29     INFO -  09-28 15:24:27.896 E/GeckoSessionTestRule( 3451): 	at org.mozilla.geckoview.GeckoSession$3.handleMessage(GeckoSession.java:533)
[task 2023-09-28T15:24:29.173Z] 15:24:29     INFO -  09-28 15:24:27.896 E/GeckoSessionTestRule( 3451): 	at org.mozilla.geckoview.GeckoSessionHandler.handleMessage(GeckoSessionHandler.java:88)
[task 2023-09-28T15:24:29.174Z] 15:24:29     INFO -  09-28 15:24:27.896 E/GeckoSessionTestRule( 3451): 	at org.mozilla.gecko.EventDispatcher$3.run(EventDispatcher.java:426)
[task 2023-09-28T15:24:29.174Z] 15:24:29     INFO -  09-28 15:24:27.896 E/GeckoSessionTestRule( 3451): 	at android.os.Handler.handleCallback(Handler.java:751)
[task 2023-09-28T15:24:29.174Z] 15:24:29     INFO -  09-28 15:24:27.896 E/GeckoSessionTestRule( 3451): 	at android.os.Handler.dispatchMessage(Handler.java:95)
[task 2023-09-28T15:24:29.174Z] 15:24:29     INFO -  09-28 15:24:27.896 E/GeckoSessionTestRule( 3451): 	at org.mozilla.geckoview.test.util.UiThreadUtils.waitForCondition(UiThreadUtils.java:158)
[task 2023-09-28T15:24:29.174Z] 15:24:29     INFO -  09-28 15:24:27.896 E/GeckoSessionTestRule( 3451): 	at org.mozilla.geckoview.test.rule.GeckoSessionTestRule.webExtensionApiCall(GeckoSessionTestRule.java:2766)
[task 2023-09-28T15:24:29.174Z] 15:24:29     INFO -  09-28 15:24:27.896 E/GeckoSessionTestRule( 3451): 	at org.mozilla.geckoview.test.rule.GeckoSessionTestRule.promiseAllPaintsDone(GeckoSessionTestRule.java:2729)
[task 2023-09-28T15:24:29.175Z] 15:24:29     INFO -  09-28 15:24:27.896 E/GeckoSessionTestRule( 3451): 	at org.mozilla.geckoview.test.BaseSessionTest.promiseAllPaintsDone(BaseSessionTest.kt:266)
[task 2023-09-28T15:24:29.175Z] 15:24:29     INFO -  09-28 15:24:27.896 E/GeckoSessionTestRule( 3451): 	at org.mozilla.geckoview.test.InputResultDetailTest.setupDocument(InputResultDetailTest.kt:23)
[task 2023-09-28T15:24:29.175Z] 15:24:29     INFO -  09-28 15:24:27.896 E/GeckoSessionTestRule( 3451): 	at org.mozilla.geckoview.test.InputResultDetailTest.testTouchAction(InputResultDetailTest.kt:99)
[task 2023-09-28T15:24:29.175Z] 15:24:29     INFO -  09-28 15:24:27.896 E/GeckoSessionTestRule( 3451): 	at java.lang.reflect.Method.invoke(Native Method)
[task 2023-09-28T15:24:29.175Z] 15:24:29     INFO -  09-28 15:24:27.896 E/GeckoSessionTestRule( 3451): 	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
[task 2023-09-28T15:24:29.175Z] 15:24:29     INFO -  09-28 15:24:27.896 E/GeckoSessionTestRule( 3451): 	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
[task 2023-09-28T15:24:29.176Z] 15:24:29     INFO -  09-28 15:24:27.896 E/GeckoSessionTestRule( 3451): 	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
[task 2023-09-28T15:24:29.176Z] 15:24:29     INFO -  09-28 15:24:27.896 E/GeckoSessionTestRule( 3451): 	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
[task 2023-09-28T15:24:29.176Z] 15:24:29     INFO -  09-28 15:24:27.896 E/GeckoSessionTestRule( 3451): 	at org.junit.rules.Verifier$1.evaluate(Verifier.java:35)
[task 2023-09-28T15:24:29.176Z] 15:24:29     INFO -  09-28 15:24:27.896 E/GeckoSessionTestRule( 3451): 	at org.mozilla.geckoview.test.rule.GeckoSessionTestRule$2.lambda$evaluate$0(GeckoSessionTestRule.java:1500)
[task 2023-09-28T15:24:29.176Z] 15:24:29     INFO -  09-28 15:24:27.896 E/GeckoSessionTestRule( 3451): 	at org.mozilla.geckoview.test.rule.GeckoSessionTestRule$2.$r8$lambda$eGWMAiU-In-hdc_ISYHPMUhHPKA(GeckoSessionTestRule.java)
[task 2023-09-28T15:24:29.176Z] 15:24:29     INFO -  09-28 15:24:27.896 E/GeckoSessionTestRule( 3451): 	at org.mozilla.geckoview.test.rule.GeckoSessionTestRule$2$$ExternalSyntheticLambda1.run(D8$$SyntheticClass)
[task 2023-09-28T15:24:29.177Z] 15:24:29     INFO -  09-28 15:24:27.896 E/GeckoSessionTestRule( 3451): 	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:428)
[task 2023-09-28T15:24:29.177Z] 15:24:29     INFO -  09-28 15:24:27.896 E/GeckoSessionTestRule( 3451): 	at java.util.concurrent.FutureTask.run(FutureTask.java:237)
[task 2023-09-28T15:24:29.177Z] 15:24:29     INFO -  09-28 15:24:27.896 E/GeckoSessionTestRule( 3451): 	at android.app.Instrumentation$SyncRunnable.run(Instrumentation.java:1950)
[task 2023-09-28T15:24:29.177Z] 15:24:29     INFO -  09-28 15:24:27.896 E/GeckoSessionTestRule( 3451): 	at android.os.Handler.handleCallback(Handler.java:751)
[task 2023-09-28T15:24:29.177Z] 15:24:29     INFO -  09-28 15:24:27.896 E/GeckoSessionTestRule( 3451): 	at android.os.Handler.dispatchMessage(Handler.java:95)
[task 2023-09-28T15:24:29.177Z] 15:24:29     INFO -  09-28 15:24:27.896 E/GeckoSessionTestRule( 3451): 	at android.os.Looper.loop(Looper.java:154)
[task 2023-09-28T15:24:29.178Z] 15:24:29     INFO -  09-28 15:24:27.896 E/GeckoSessionTestRule( 3451): 	at android.app.ActivityThread.main(ActivityThread.java:6077)
[task 2023-09-28T15:24:29.178Z] 15:24:29     INFO -  09-28 15:24:27.896 E/GeckoSessionTestRule( 3451): 	at java.lang.reflect.Method.invoke(Native Method)
[task 2023-09-28T15:24:29.178Z] 15:24:29     INFO -  09-28 15:24:27.896 E/GeckoSessionTestRule( 3451): 	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:866)
[task 2023-09-28T15:24:29.178Z] 15:24:29     INFO -  09-28 15:24:27.896 E/GeckoSessionTestRule( 3451): 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:756)
[task 2023-09-28T15:24:29.178Z] 15:24:29     INFO -  09-28 15:24:27.897 D/GeckoViewNavigation( 3451): canClose
[task 2023-09-28T15:24:29.178Z] 15:24:29     INFO -  09-28 15:24:27.905 D/GeckoViewClipboardPermissionChild[C]( 3451): handleEvent: pagehide
[task 2023-09-28T15:24:29.178Z] 15:24:29     INFO -  09-28 15:24:27.912 D/GeckoThread( 3451): State changed to EXITING
[task 2023-09-28T15:24:29.179Z] 15:24:29     INFO -  09-28 15:24:27.914 E/GeckoConsole( 3451): [JavaScript Error: "TypeError: can't access property "sendAsyncMessage", this._manager.messageManager is null" {file: "chrome://geckoview/content/geckoview.js" line: 518}]
[task 2023-09-28T15:24:29.179Z] 15:24:29     INFO -  09-28 15:24:27.914 E/GeckoConsole( 3451): _updateContentModuleState@chrome://geckoview/content/geckoview.js:518:5
[task 2023-09-28T15:24:29.179Z] 15:24:29     INFO -  09-28 15:24:27.914 E/GeckoConsole( 3451): set enabled@chrome://geckoview/content/geckoview.js:493:10
[task 2023-09-28T15:24:29.179Z] 15:24:29     INFO -  09-28 15:24:27.914 E/GeckoConsole( 3451): init/</<@chrome://geckoview/content/geckoview.js:115:9
[task 2023-09-28T15:24:29.179Z] 15:24:29     INFO -  09-28 15:24:27.914 E/GeckoConsole( 3451): forEach@chrome://geckoview/content/geckoview.js:168:19
[task 2023-09-28T15:24:29.179Z] 15:24:29     INFO -  09-28 15:24:27.914 E/GeckoConsole( 3451): init/<@chrome://geckoview/content/geckoview.js:114:12
[task 2023-09-28T15:24:29.179Z] 15:24:29     INFO -  09-28 15:24:27.916 D/GeckoViewProgress( 3451): ProgressTracker onStateChange: isTopLevel=true, flags=0xc0010, status=NS_ERROR_ABORT
[task 2023-09-28T15:24:29.180Z] 15:24:29     INFO -  09-28 15:24:27.916 D/GeckoViewProgress( 3451): ProgressTracker onStateChange: uri=http://localhost:4245/assets/www/touch-action.html?subframe&scrollable&event&touch-action=pan-x
[task 2023-09-28T15:24:29.180Z] 15:24:29     INFO -  09-28 15:24:27.917 D/GeckoViewProgress( 3451): ProgressTracker stop
[task 2023-09-28T15:24:29.180Z] 15:24:29     INFO -  09-28 15:24:27.917 D/GeckoViewProgress( 3451): StateTracker onStateChange: isTopLevel=true, flags=0xc0010, status=NS_ERROR_ABORT loadType=1
[task 2023-09-28T15:24:29.180Z] 15:24:29     INFO -  09-28 15:24:27.922 D/EGL_emulation( 7080): eglMakeCurrent: 0x7ef5cf07c800: ver 3 0 (tinfo 0x7ef5c49c0120)
[task 2023-09-28T15:24:29.180Z] 15:24:29     INFO -  09-28 15:24:27.923 E/eglCodecCommon( 7080): glUtilsParamSize: unknow param 0x00008caa
[task 2023-09-28T15:24:29.180Z] 15:24:29     INFO -  09-28 15:24:27.928 D/GeckoViewConsole( 3451): onEvent GeckoView:WebExtension:List null
[task 2023-09-28T15:24:29.181Z] 15:24:29     INFO -  09-28 15:24:27.930 E/GeckoSessionTestRule( 3451): test_end c5ee677f-bc83-49bd-9e28-2d35f3d0f059 testTouchAction(org.mozilla.geckoview.test.InputResultDetailTest)
[task 2023-09-28T15:24:29.181Z] 15:24:29  WARNING -  TEST-UNEXPECTED-FAIL | org.mozilla.geckoview.test.InputResultDetailTest#testTouchAction | org.mozilla.geckoview.test.rule.GeckoSessionTestRule$ChildCrashedException: Child process crashed
[task 2023-09-28T15:24:29.181Z] 15:24:29     INFO -  TEST-INFO took 1523ms
Flags: needinfo?(dshin)
Blocks: 1855753
See Also: → 1855809

Filed bug 1855809 for more investigation, but since we call the offending function directly from RestyleManager, we can just supply the snapshots directly.

Flags: needinfo?(dshin)
Pushed by dshin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/542e64824033
`:has` invalidation for inner selectors. r=emilio
Duplicate of this bug: 1855753
Pushed by csabou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/15e45fa86733
Remove .ini file for invalidation-003 as it's no longer needed. a=test-only

https://hg.mozilla.org/mozilla-central/rev/542e64824033
https://hg.mozilla.org/mozilla-central/rev/15e45fa86733

Status: ASSIGNED → RESOLVED
Closed: 11 months ago
status-firefox120: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 120 Branch
Regressions: 1855954
Duplicate of this bug: 1855738
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/42246 for changes under testing/web-platform/tests
Upstream PR merged by moz-wptsync-bot
Duplicate of this bug: 1771020
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: