has-complexity times out on opt builds
Categories
(Core :: CSS Parsing and Computation, defect)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox121 | --- | fixed |
People
(Reporter: dshin, Assigned: dshin)
References
Details
Attachments
(3 files)
Introduced here
| Assignee | ||
Updated•1 year ago
|
| Assignee | ||
Comment 1•1 year ago
|
||
From local opt build with modified has-complexity.html that runs the highlighted portion on button click, but with 10000 elements: https://share.firefox.dev/3ECI0FM
Right.. so the invalidator is trying to find .subject, and running across all instances of #container > span, which is in the same subtree as .subject from main.
Comment 2•1 year ago
|
||
We're also failing the related WPT with a timeout: https://wpt.fyi/results/css/selectors/invalidation/has-complexity.html
Updated•1 year ago
|
| Assignee | ||
Comment 3•1 year ago
|
||
This is slightly more efficient as invalidations are added after duplicates have been removed.
We will be running some matching that we definitely do not want to run on duplicates.
Updated•1 year ago
|
| Assignee | ||
Comment 4•1 year ago
|
||
Required for upcoming optimization.
Also use the added information to move invalidation acceptance logic.
Depends on D191305
| Assignee | ||
Comment 5•1 year ago
|
||
There are cases where we can run a selector match to realize that some DOM mutations
will not make a difference in the relative selector match state, which avoids
O(n^2) behaviour under some circumstances.
Depends on D191306
Comment 7•1 year ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/43c5a48d4a2f
https://hg.mozilla.org/mozilla-central/rev/4866d633239c
https://hg.mozilla.org/mozilla-central/rev/5e5e1e48b9bb
Description
•