Lonnen :lonnen Reporter
	Description • 13 years ago

When there are multiple tabs open, and the Inbox tab has focus, command-W and File -> Close do not do anything. If I click the red X, the window closes. When it is restored, my tabs are all still there. 

When only the Inbox tab is open, command-W or File -> Close will close the main window.

I expect that hitting command-W will close the application window if I am on the uncloseable inbox tab. 

Minimally, the close window option should be disabled completely in the UI, so that hitting the hotkey doesn't trigger the blue blink in my menu bar. It is frustrating to see the blue blink acknowledging my keystroke or mouse click without the app responding.

	Thomas D. (:thomas8)
	Comment 1 • 13 years ago

(In reply to Chris Lonnen :lonnen from comment #0)
> When there are multiple tabs open, and the Inbox tab has focus, command-W
> and File -> Close do not do anything.

Chris, thanks for filing this. Step-by-Step STR, then separate sections for 'Actual Result' and 'Expected Result' would make things a lot easier for QA...
...and reveal that the RFE and minimal bugfix parts of this bug are mutually exclusive, so a decision needs to be taken!

> If I click the red X, the window
> closes. When it is restored, my tabs are all still there.

I assume that's the application's red [x], so anything surprising here? (I'd think no).

> When only the Inbox tab is open, command-W or File -> Close will close the
> main window.

The idea here is that this is the last tab, and closing the last tab closes the window (which is ok, and seems ok for Chris, too).

> I expect that hitting command-W will close the application window if I am on
> the uncloseable inbox tab.

That's a feature request:

STR
1) have multiple tabs open
2) focus on the first/main tab ("uncloseable inbox tab")
3) hit Ctrl+W / command-W or try File > Close (which are enabled -> bug, see below)

Actual result
- nothing (but a flash response from the menu on Macs)

Expected result (RFE by Chris)
- close the main application window (with whichever tabs happen to be open)

I'd recommend "wontfix" for this RFE. Ctrl+W is a shortcut for closing sub-windows or tabs, not the main window/application. Of course, when there is only *one* subwindow/tab, we accept it for closing the app, too, which is helpful. However, closing the app instead of the current tab (inbox), as requested by this RFE, is error-prone (ux-error-prevention, ux-consistency). Therefore, I recommend only implementing the minimal fix as outlined by Chris below.
 
> Minimally, the close window option should be disabled completely in the UI,
> so that hitting the hotkey doesn't trigger the blue blink in my menu bar. It
> is frustrating to see the blue blink acknowledging my keystroke or mouse
> click without the app responding.

This describes the bug in the current behaviour (ux-consistency).
More precisely:

STR
1) have multiple tabs open
2) focus on the first/main tab ("uncloseable inbox tab")
3) hit Ctrl+W / command-W or try File > Close (which is enabled -> bug, see below)

Actual result
- nothing

Expected result (minimal bugfix by Chris, and recommended by Thomas)
- disable Ctrl+W and File > Close as we don't allow closing the main tab when multiple tabs are open (and we can't tell if the user actually wants to close the /app/, so we do nothing as a matter of ux-error-prevention).

Blake, what do you think?
- ok to wontfix the RFE, and just fix the ux-consistency bug?

	Blake Winton (:bwinton) (:☕️)
	Comment 2 • 13 years ago

Yeah, I think hitting Ctrl-W to close a tab, and having the entire application go away would be too surprising, but greying out the menu item when we can't use it seems reasonable.

	Wayne Mery (:wsmwk)
	Comment 3 • 11 years ago

I haven't totally sorted this in my mind (and probably won't) but for some reason today I closed TB 2-3 times with ctrl+w, not expecting it to close. Perhaps it was the beer at dinner.

Anyway, i'd like ctrl+W to NOT close TB under any circumstance - hitting ctrl+W too many times when closing tabs is the trivial example.  

Note also firefox at some point added ctrl+shift+W for close window.

ref also bug 236721 comment 10

irving, any thoughts?

	:Irving Reid (No longer working on Firefox)
	Comment 4 • 11 years ago

I agree that it's annoying to have TB exit when you press "close tab" in the only 3-pane window you have open; beyond that I don't have any thoughts.