Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for merging pull request #352

Closed
aeschli opened this issue Aug 31, 2018 · 2 comments
Closed

Add support for merging pull request #352

aeschli opened this issue Aug 31, 2018 · 2 comments
Labels
feature-request Request for new features or functionality
Milestone
September 2018

Comments

@aeschli
Copy link
Contributor

aeschli commented Aug 31, 2018

Trying the extension the first time, I reviewed all changes (even clicked on 'Approve') but didn't find an action to merge the PR.
Closing was there.
@RMacfarlane RMacfarlane added the feature-request Request for new features or functionality label Aug 31, 2018
@RMacfarlane RMacfarlane added this to the September 2018 milestone Sep 5, 2018
@pke
Copy link

pke commented Sep 11, 2018

Seems this option is missing atm?

@RMacfarlane
Copy link
Contributor

@pke Correct, this hasn't been implemented yet. We're working on adding it soon

@RMacfarlane RMacfarlane changed the title How do I merge the pull request? Add support for merging pull request Sep 12, 2018
Ikuyadeu added a commit to Ikuyadeu/vscode-pull-request-github that referenced this issue Sep 14, 2018
@Ikuyadeu
Implement merge button, fixes microsoft#352
a9f3a3e
@Ikuyadeu Ikuyadeu mentioned this issue Sep 14, 2018
Merged
RMacfarlane pushed a commit that referenced this issue Oct 2, 2018
@Ikuyadeu
Implement merge button, fixes #352 (#485)
8778a7f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request Request for new features or functionality
Projects
None yet
Milestone
September 2018
Development

No branches or pull requests
3 participants
@pke @RMacfarlane @aeschli