Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loosen scope restrictions for older versions of GHE #507

Closed
shana opened this issue Sep 20, 2018 · 0 comments
Closed

Loosen scope restrictions for older versions of GHE #507

shana opened this issue Sep 20, 2018 · 0 comments

Comments

@shana
Copy link
Contributor

shana commented Sep 20, 2018

From #432 (comment):

i did not see the scope write:discussion, is it because GHE admin turned it off or simply GHE version thing? mine is GitHub Enterprise 2.11.18

The write:discussion scope is a newer scope that older versions of GHE don't have (or have under a different name). Most of the features of the extension don't require this scope (it's mainly for team discussions), so it won't break functionality if this scope is optional when validating scopes.

This only affects validating personal access tokens created manually by the user for GHE hosts (not github.com), as the sign in process is only available in versions of GHE that also include the write:discussion scope.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant