Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is the Rewrite DNS example correct? #109609

Open
kmorwath opened this issue May 16, 2023 · 5 comments
Open

Is the Rewrite DNS example correct? #109609

kmorwath opened this issue May 16, 2023 · 5 comments
Assignees
@sf-msft
Labels
aks-networking/subsvc assigned-to-author azure-kubernetes-service/svc doc-bug Pri2 triaged

Comments

@kmorwath
Copy link

kmorwath commented May 16, 2023 •
edited
Loading

I might have found two problems with the "Rewrite DNS" example.

  1. name regex (.)\.<domain to be rewritten>.com needs a \ before .com: name regex (.)\.<domain to be rewritten>\.com. Here also it is advised to match the end of the string: Custom DNS Entries For Kubernetes using rewrite not working always coredns/coredns#2347

  2. As far as I can see, the main CoreDNS configmap has "import custom/*.server" as the last line. If the stanza beginning with ".:53" catches any domain and has the precedence, it becomes impossibile for a .server file to handle any other domain. I'm trying to use the example, but always get a NXDOMAIN answer.

Document Details

⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.
@kmorwath
Copy link
Author

Using an .override instead of .server does work, since the rewrite is "pushed" inside the main stanza.

@kmorwath kmorwath changed the title Is the example correct? Is the Rewrite DNS example correct? May 16, 2023
@YashikaTyagii
Copy link
Contributor

@kmorwath
Thanks for your feedback! We will investigate and update as appropriate.

@AjayBathini-MSFT
Copy link
Contributor

@kmorwath
Thanks for bringing this to our attention.
I'm going to assign this to the document author so they can take a look at it accordingly.

@sf-msft
Copy link
Contributor

sf-msft commented Jun 19, 2024

#reassign:sf-msft

@prmerger-automator prmerger-automator bot assigned sf-msft and unassigned asudbring Jun 19, 2024
@rayoef
Copy link
Contributor

rayoef commented Jul 12, 2024

Hi @sf-msft - is this GitHub issue addressed through your update? If so, can you close it, please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sf-msft sf-msft

Labels
aks-networking/subsvc assigned-to-author azure-kubernetes-service/svc doc-bug Pri2 triaged
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@kmorwath @asudbring @rayoef @YashikaTyagii @AjayBathini-MSFT @sf-msft