Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Page contains contradiction #91514

Closed
bluefirepatrick opened this issue Apr 13, 2022 · 4 comments
Closed

Page contains contradiction #91514

bluefirepatrick opened this issue Apr 13, 2022 · 4 comments
Assignees
@msangapu-msft
Labels
app-service/svc assigned-to-author doc-idea Pri2 triaged

Comments

@bluefirepatrick
Copy link

This page contains some contradictions that are confusing.

In the first paragraph it states that the App Service runs npm install --production when you deploy from a Git repository or a zip file with build automation enabled. However in the Customize Build Automation section it states, in step 2, that it runs npm install without any flags. In node.js-land that is a big difference.

Also, back in the first paragraph it talks about deploying from 'a Git repository or a zip file with build automation enabled'. I think the use of 'with' there could be interpreted to mean that the build automation flag only applies when using zip file.

Also, 'deploying from a Git repository' could be interpreted as using Github Actions where npm install usually happens on a Github runner and not on Azure at all.

I write this only because I honestly found the descriptions in the article confusing; there is so little documentation on deploying node to Azure in production that if the few articles on it could be more clear it could save people hours of time.

Thanks.

Document Details

⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.
@RyanHill-MSFT
Copy link
Contributor

Thanks for the feedback @bluefirepatrick. I do want to point out a couple of things that you mentioned. The sentence you referenced, _a Git repository or a zip file with build automation enabled_.

Git repository is linked to https://docs.microsoft.com/en-us/azure/app-service/deploy-local-git which explains using the platform to build your app. Zip file links to https://docs.microsoft.com/en-us/azure/app-service/deploy-zip which explains that deployment method and breaks down the various options it provides. Build automation enabled links to https://docs.microsoft.com/en-us/azure/app-service/deploy-zip#enable-build-automation-for-zip-deploy which is associated with zip deploy explains how to enable a build on the platform if your deployment method is via zip.

I've assigned this issue to content author to investigate further and update the document as appropriate.

@cephalin
Copy link
Contributor

#reassign:msangapu-msft

@msangapu-msft
Copy link
Contributor

#needs-sme-input

@msangapu-msft
Copy link
Contributor

Thank you for your feedback. We've added this to our backlog to review and update as needed. #please-close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@msangapu-msft msangapu-msft

Labels
app-service/svc assigned-to-author doc-idea Pri2 triaged
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@bluefirepatrick @cephalin @PRMerger15 @RyanHill-MSFT @msangapu-msft