-
Notifications
You must be signed in to change notification settings - Fork 21.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgraded wrong variables declarations #120381
Conversation
Learn Build status updates of commit ea566ff: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
@microsoft-github-policy-service agree |
@L3onard80 : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
#label:"aq-pr-triaged" |
Can you review this old PR and determine whether it needs to be closed or merged? @MicrosoftDocs/public-repo-pr-review-team |
we maintain powershell script for windows environment and cli scripts for the linux environment. This script should work fine in linux environment. I believe the suggested changes are for windows environment. |
Yes, for Windows btw.
Il Mer 1 Mag 2024, 07:40 Raman Kumar ***@***.***> ha scritto:
… we maintain powershell script for windows environment and cli scripts for
the linux environment. This script should work fine in linux environment. I
believe the suggested changes are for windows environment.
—
Reply to this email directly, view it on GitHub
<#120381 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/APB5HQZ43I7A776WNV7GT4DZAB533AVCNFSM6AAAAABECN7MSKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBYGAYDSNJQG4>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
I emailed the content owner today. |
I sent a Teams message to the content owner today. |
Hi @L3onard80 - CLI scripts all follow bash syntax, so this change won’t be accepted. If you'd still like to update the article, please open a new PR. Or if you believe this PR was closed by mistake, email the PublicPRs alias. #please-close |
Hi,l Courtney, what u wrote is not correct. Powershell syntax is different
from bash and that piece of code without modification does not work.
Il Mer 7 Ago 2024, 17:44 prmerger-automator[bot] ***@***.***>
ha scritto:
… Closed #120381 <#120381>.
—
Reply to this email directly, view it on GitHub
<#120381 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/APB5HQ5MEAA6ZNCFTBVUYKTZQI6ENAVCNFSM6AAAAABECN7MSKVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJTG44TINJQG4ZTCOI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Hi, i've noticed that the scripts on the page missing the "$" and double quotes for declarations.