Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded wrong variables declarations #120381

Closed
wants to merge 1 commit into from

Conversation

L3onard80
Copy link

Hi, i've noticed that the scripts on the page missing the "$" and double quotes for declarations.

Copy link
Contributor

Learn Build status updates of commit ea566ff:

✅ Validation status: passed

File Status Preview URL Details
articles/virtual-machines/scripts/copy-managed-disks-to-same-or-different-subscription.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@L3onard80 L3onard80 changed the title Upgrade wrong variables declarations Upgraded wrong variables declarations Mar 1, 2024
@L3onard80
Copy link
Author

@microsoft-github-policy-service agree

Copy link
Contributor

@L3onard80 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@Jak-MS
Copy link
Contributor

Jak-MS commented Mar 1, 2024

@ramankumarlive

  • Can you review this PR?
  • IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged tracking label for the PR review team label Mar 1, 2024
@ttorble
Copy link
Contributor

ttorble commented Apr 14, 2024

@ramankumarlive

Can you review this old PR and determine whether it needs to be closed or merged?

@MicrosoftDocs/public-repo-pr-review-team

@ramankumarlive
Copy link
Contributor

we maintain powershell script for windows environment and cli scripts for the linux environment. This script should work fine in linux environment. I believe the suggested changes are for windows environment.

@L3onard80
Copy link
Author

L3onard80 commented May 1, 2024 via email

@ShannonLeavitt
Copy link
Contributor

I emailed the content owner today.

@Court72
Copy link
Contributor

Court72 commented Jul 30, 2024

I sent a Teams message to the content owner today.

@Court72
Copy link
Contributor

Court72 commented Aug 7, 2024

Hi @L3onard80 - CLI scripts all follow bash syntax, so this change won’t be accepted. If you'd still like to update the article, please open a new PR. Or if you believe this PR was closed by mistake, email the PublicPRs alias.

#please-close

@L3onard80
Copy link
Author

L3onard80 commented Aug 7, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants