-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate "Privacy, search, and services" into "Privacy and security" & "Search and services" #3127
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Writer/Editor review: Move away from heavy reliance on special urls; state the GUI nav path instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved per Writer/Editor review, after pushing commits to reword from special shortcut URL edge://settings/privacy
to standard GUI nav path format.
Caveat: Don't have latest UI, to check GUI nav path & UI strings.
Learn Build status updates of commit af343e3: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Learn Build status updates of commit c6d8398: 💡 Validation status: suggestions
microsoft-edge/privacy-whitepaper/index.md
For more details, please refer to the build report. Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. For any questions, please:
|
Learn Build status updates of commit 56666c1: 💡 Validation status: suggestions
microsoft-edge/privacy-whitepaper/index.md
For more details, please refer to the build report. Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. For any questions, please:
|
Learn Build status updates of commit 050c878: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
@@ -43,7 +43,7 @@ When you select the Address bar, a signal is sent to your default search provide | |||
|
|||
You can control whether typed characters are sent to your default search provider to provide search and site suggestions. To enable or disable sending your typed characters in the Address bar to your default search provider: | |||
|
|||
1. Select **Settings and more** (![Settings and more icon](./index-images/settings-and-more-icon.png)) > **Settings** > **Privacy, search, and services**.<!--edge://settings/privacy--> | |||
1. Select **Settings and more** (![Settings and more icon](./index-images/settings-and-more-icon.png)) > **Settings** > **Privacy, search, and services**.<!-- todo: update as separate groups of settings --><!--edge://settings/privacy--> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did the toggle Show me search and site suggestions using my typed characters end up in "Privacy and security" or "Search and services"?
@PatrizioBytes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls help integrate these incoming steps from the rewrite of the Address Bar h2 section that's in "main" branch, into this PR's scenario of separating the "Privacy, search, and services" settings into "Privacy and security" & "Search and services".
@@ -65,7 +65,7 @@ Your administrator can choose to turn on or off the work- or school-related resu | |||
<!-- ------------------------------ --> | |||
#### Preventing sending information about suggested queries | |||
|
|||
To prevent sending information about suggested queries to Microsoft, select **Settings and more** (![Settings and more icon](./index-images/settings-and-more-icon.png)) > **Settings** > **Privacy, search, and services**, and then in the **Search and service improvement** section, turn off the toggle **Help improve Microsoft products by sending the results from searches on the web**. Even if this setting is on, information about suggested queries is not associated with you or your device. | |||
To prevent sending information about suggested queries to Microsoft, select **Settings and more** (![Settings and more icon](./index-images/settings-and-more-icon.png)) > **Settings** > **Privacy, search, and services**,<!-- todo: update as separate groups of settings --> and then in the **Search and service improvement** section, turn off the toggle **Help improve Microsoft products by sending the results from searches on the web**. Even if this setting is on, information about suggested queries is not associated with you or your device. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did the toggle Help improve Microsoft products by sending the results from searches on the web end up in "Privacy and security" or "Search and services"?
@PatrizioBytes
@@ -82,15 +82,19 @@ If Microsoft Edge detects typing in the Address bar that might contain sensitive | |||
<!-- ------------------------------ --> | |||
#### Enabling collecting Address bar diagnostic data | |||
|
|||
You can configure Microsoft Edge to collect diagnostic data about the Address bar. Collected data includes the number of offered queries for all search providers.<!-- todo: is the number of offered queries the only data that's collected through diagnostic data? if not, shouldn't list that one only. specify for Enterprise Search Provider & specify for all providers --> To enable collecting diagnostic data, select **Settings and more** (![Settings and more icon](./index-images/settings-and-more-icon.png)) > **Settings** > **Privacy, search, and services**, and then in the **Personalization & advertising** section, turn on the setting **Allow Microsoft to save your browsing activity including history, usage, favorites, web content, and other browsing data to personalize Microsoft Edge and Microsoft services like ads, search, shopping and news.** | |||
You can configure Microsoft Edge to collect diagnostic data about the Address bar. Collected data includes the number of offered queries for all search providers.<!-- todo: is the number of offered queries the only data that's collected through diagnostic data? if not, shouldn't list that one only. specify for Enterprise Search Provider & specify for all providers --> To enable collecting diagnostic data, select **Settings and more** (![Settings and more icon](./index-images/settings-and-more-icon.png)) > **Settings** > **Privacy, search, and services**,<!-- todo: update as separate groups of settings --> and then in the **Personalization & advertising** section, turn on the setting **Allow Microsoft to save your browsing activity including history, usage, favorites, web content, and other browsing data to personalize Microsoft Edge and Microsoft services like ads, search, shopping and news.** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did the toggle Allow Microsoft to save your browsing activity including history, usage, favorites, web content, and other browsing data to personalize Microsoft Edge and Microsoft services like ads, search, shopping and news end up in "Privacy and security" or "Search and services"?
@PatrizioBytes
|
||
|
||
<!-- ------------------------------ --> | ||
#### Deleting data | ||
|
||
Typed characters and the websites that you visit are stored locally on the device, per profile. To delete that data, select **Settings and more** (![Settings and more icon](./index-images/settings-and-more-icon.png)) > **Settings** > **Privacy, search, and services**, and then in the **Delete browsing data** section, click the **Choose what to clear** button; then in the **Delete browsing data** dialog, click the **Clear now** button. | ||
Typed characters and the websites that you visit are stored locally on the device, per profile. To delete that data, select **Settings and more** (![Settings and more icon](./index-images/settings-and-more-icon.png)) > **Settings** > **Privacy, search, and services**,<!-- todo: update as separate groups of settings --> and then in the **Delete browsing data** section, click the **Choose what to clear** button; then in the **Delete browsing data** dialog, click the **Clear now** button. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did this UI end up in "Privacy and security" or "Search and services"? --
in the Delete browsing data section, click the Choose what to clear button; then in the Delete browsing data dialog, click the Clear now button.
@PatrizioBytes
If Bing is your default search provider and you are signed in,<!-- todo: reformat paragraph as 3 list items starting here? --> you can delete your searches by using the [Microsoft Privacy dashboard](https://account.microsoft.com/privacy/). To clear your browsing history and delete websites from appearing as suggestions in the Address bar: select **Settings and more** (![Settings and more icon](./index-images/settings-and-more-icon.png)) > **Settings** > **Privacy, search, and services**, and then in the **Delete browsing data** section, click the **Choose what to clear** button; then in the **Delete browsing data** dialog, click the **Clear now** button. You can delete the data that Microsoft collects from the Address bar and search suggestions features on Windows 10 and later: open **Start** > **Settings** > **Privacy** > **Diagnostics & feedback**, and then in **Delete diagnostic data**, select **Delete**.<!-- todo: is this sentence about Start menu for the correct feature? seems to be about deleting Edge data from within the OS rather than from within Edge --><!-- old comment: deleting diagnostic data could use rewrite --> All other data is deleted after 36 months.<!-- todo: what is "all other data"? --> | ||
If Bing is your default search provider and you are signed in,<!-- todo: reformat paragraph as 3 list items starting here? --> you can delete your searches by using the [Microsoft Privacy dashboard](https://account.microsoft.com/privacy/). | ||
|
||
To clear your browsing history and delete websites from appearing as suggestions in the Address bar: select **Settings and more** (![Settings and more icon](./index-images/settings-and-more-icon.png)) > **Settings** > **Privacy, search, and services**,<!-- todo: update as separate groups of settings --> and then in the **Delete browsing data** section, click the **Choose what to clear** button; then in the **Delete browsing data** dialog, click the **Clear now** button. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2nd instance:
did this UI end up in "Privacy and security" or "Search and services"? --
in the Delete browsing data section, click the Choose what to clear button; then in the Delete browsing data dialog, click the Clear now button.
@PatrizioBytes
Learn Build status updates of commit 60d17a9: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Learn Build status updates of commit e8f575d: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Learn Build status updates of commit 91c9038: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Rendered article for review:
Microsoft Edge > Settings and more > Settings > Privacy, search, and services is getting split into two sections:
That change impacts the Microsoft Edge Privacy Whitepaper, which mentions the old combined section, and mentions "edge://settings/privacy" 36 times. Two other articles also mention "edge://settings/privacy".
The goal of this PR is to ready the docs for when the combined section will get replaced by the two new sections in the near future.
This PR also makes the following changes:
AB#50096302