Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"NotImplementedException" from OwnershipHandler.cs #20

Closed
nooxouille opened this issue Aug 21, 2020 · 7 comments
Closed

"NotImplementedException" from OwnershipHandler.cs #20

nooxouille opened this issue Aug 21, 2020 · 7 comments

Comments

@nooxouille
Copy link

Hi there! From Multi-user capabilities got a "NotImplementedException" #8311, filling something here as the issue is related to the tutorial :)

As explained in the MRTK issue, I was wondering the reason behind the "throw new NotImplementedException() " inside OnInputUp(), OnOwnershipTransfered() and OnTriggerExit() as it fire an error.
Is it for a future update of the series, or is it something that we (as users) have to fullfill according to our needs ?

The script is located at MRTK.Tutorials.MultiUserCapabilities/Scripts/OwnershipHandler.cs

Additional context

Again, I might be missing an obvious point here because of my lack of knowledge on certain points because of my "weak" background in software development.


Document Details

Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

@hferrone
Copy link
Contributor

@mr0ng @martinwilter Can you confirm?

@martinwilter
Copy link
Contributor

Hi @nooxouille,

Sorry for the confusion. Those are required delegate members that are not used in the project, you can comment out the body like you already did.

@hferrone, this shouldn't prevent users from running the completed app, but I can see how it is confusing. I will update the tutorial assets later this week.

CC @mr0ng

@nooxouille
Copy link
Author

@martinwilter Thank you for the clarification. It is indeed confusing as the error prevent the compilation and therefore, to run the samples.

@hferrone
Copy link
Contributor

@martinwilter Did this get updated?

@martinwilter
Copy link
Contributor

@hferrone, I should be able to get this done today, I'll ping you here once the patch has been released.

martinwilter pushed a commit to onginnovations/MixedRealityLearning that referenced this issue Aug 29, 2020
@martinwilter
Copy link
Contributor

@hferrone, the asset has been updated.

@nooxouille, just as an FYI, the reason your testing in the Unity editor was interrupted by the 'NotImplementedException' logs is because you had 'Error Pause' enabled, you can toggle it on/off by clicking the button in the Console window. Anyway, it's best without those appearing in the console logs, so thanks for pointing this out.

@nooxouille
Copy link
Author

@nooxouille, just as an FYI, the reason your testing in the Unity editor was interrupted by the 'NotImplementedException' logs is because you had 'Error Pause' enabled, you can toggle it on/off by clicking the button in the Console window. Anyway, it's best without those appearing in the console logs, so thanks for pointing this out.

Oh! Thx for the tip! Always happy to help :)

@hferrone hferrone closed this as completed Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants