Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ContentFiles are not added as link items in standard PackageReference #5958

Closed
jainaashish opened this issue Sep 29, 2017 · 1 comment
Closed

ContentFiles are not added as link items in standard PackageReference #5958

jainaashish opened this issue Sep 29, 2017 · 1 comment
Assignees
@jainaashish
Labels
Style:PackageReference Type:Bug
Milestone
4.5 - Oct3-Oct21

Comments

@jainaashish
Copy link
Contributor

ContentFiles are not being added as link items in normal project system in PackageReference

Steps:

  1. create c# class library
  2. Install package contentfilesexample -v 1.0.2 as PackageReference

Expected:
It should have added content files as link items into the project. They should have also be available in projectName.csproj.nuget.g.props file

Actual:
Content files are neither in project system nor in .props file. Although they are there in project.assets.json file.
@nkolev92 nkolev92 mentioned this issue Sep 29, 2017
Open
39 tasks
@rohit21agrawal rohit21agrawal added this to the 4.5 milestone Sep 29, 2017
@jainaashish jainaashish modified the milestones: 4.5, 4.5 - Oct3-Oct21 Oct 1, 2017
@jainaashish
Copy link
Contributor Author

We explicitly avoid adding these content files into projectName.csproj.nuget.g.props file with the help of skipContentFileWrite flag in assets file. Because classic project system build tasks takes care of these content files and making them available as part of projects via design-time builds.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jainaashish jainaashish

Labels
Style:PackageReference Type:Bug
Projects
None yet
Milestone
4.5 - Oct3-Oct21
Development

No branches or pull requests
2 participants
@rohit21agrawal @jainaashish