Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explain package authors and owner hyperlinks in PM UI #3316

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Explain package authors and owner hyperlinks in PM UI #3316

merged 1 commit into from
Jul 15, 2024

Conversation

donnie-msft
Copy link
Contributor

@donnie-msft donnie-msft commented Jul 13, 2024 •
edited
Loading

Fixes: https://github.com/NuGet/Client.Engineering/issues/2916

  • Update screenshot of Browse tab to include Package Owner Profile hyperlinks
  • Expand paragraph into a bulleted list for readability
  • Create a !Note to explain 17.11+ supporting package profile hyperlinks. Previous versions always show package author.
  • Link to both nuget.org's package ownership process, and to the best explanation for authoring packages.
  • FYI, suggest improving nuspec author best practice verbiage in De-emphasize Nuspec authors references to nuget.org NuGetGallery#10070

@donnie-msft donnie-msft requested review from a team as code owners July 13, 2024 01:44
@learn-build-service-prod Learn Build Service (PROD)

This comment was marked as outdated.

Sign in to view
@donnie-msft donnie-msft force-pushed the dev-donnie-msft-ownerLinkDocs branch from 9ab632b to 0c0163b Compare July 13, 2024 04:33
@learn-build-service-prod Learn Build Service (PROD)

This comment was marked as outdated.

Sign in to view
@donnie-msft donnie-msft force-pushed the dev-donnie-msft-ownerLinkDocs branch from 0c0163b to 804f9fe Compare July 13, 2024 04:38
@learn-build-service-prod Learn Build Service (PROD)

This comment was marked as outdated.

Sign in to view
@donnie-msft donnie-msft force-pushed the dev-donnie-msft-ownerLinkDocs branch from 804f9fe to 26f3f2e Compare July 13, 2024 04:45
@learn-build-service-prod Learn Build Service (PROD)
Copy link

Learn Build status updates of commit 26f3f2e:

💡 Validation status: suggestions

File Status Preview URL Details
docs/consume-packages/install-use-packages-visual-studio.md 💡Suggestion View Details
docs/consume-packages/media/package-manager-browse-tab.png ✅Succeeded View

docs/consume-packages/install-use-packages-visual-studio.md

  • Line 198, Column 3: [Suggestion: learn-site-link-broken - See documentation] Link '/shows/nuget-101/install-and-use-a-nuget-package-with-visual-studio-2-of-5/player' points to a learn site page that doesn't exist. Check the path or URL and update the link.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@donnie-msft donnie-msft mentioned this pull request Jul 15, 2024
Merged
JonDouglas
JonDouglas approved these changes Jul 15, 2024
View reviewed changes
Copy link
Contributor

@JonDouglas JonDouglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, gonna merge!

@JonDouglas JonDouglas merged commit 93b8700 into main Jul 15, 2024
2 checks passed
@JonDouglas JonDouglas deleted the dev-donnie-msft-ownerLinkDocs branch July 15, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonDouglas JonDouglas JonDouglas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@donnie-msft @JonDouglas