-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unnecessary build dependencies and CMake requirements for interfaces since DP3 #63
Comments
Thank you for the feedback! We initially set the minimum CMake version to As for your second point, we agree that the |
Hi! I am running into the error: --- stderr: isaac_ros_common
CMake Error at CMakeLists.txt:9 (cmake_minimum_required):
CMake 3.23.1 or higher is required. You are running version 3.22.1
--- I think it is related with the comment @travipross did above on:
I was wondering if this has this been addressed without building CMake from source? Thank you in advance! |
We're testing this right now, and we'll report back once we've validated the downgraded version of CMake. Thanks for your patience! |
Fix in Isaac ROS 2.0.0 available now. Thanks for flagging this! Please verify and close as appropriate. |
The
isaac_ros_tensor_list_interfaces
package (likely among others), since the DP3 update, now has a dependency onisaac_ros_common
, and similarly now requires a minimumCMake
version of3.23.2
(presumably both of these changes have something to do with trying to load common CMake arguments as per this file).This introduces a challenging breaking change to resolve for those looking to develop lightweight nodes who depend solely on these interfaces. I'd argue that there is no compelling reason to make this interface package depend on the
isaac_ros_common
package (and therefore its upstream dependencies), as it's solely providing some.msg
definitions. It also does not warrant such a high CMake version requirement.Some specific scenarios/challenges that I've encountered when trying to develop a node that subscribes to the a TensorList topic as published by
isaac_ros_dnn_inference
running a Triton Inference Server:isaac_ros_common
: There should be no need forisaac_ros_common
to be a dependency of this interfaces package, as all defined message types contained withinisaac_ros_tensor_list_interfaces
can safely be compiled without this dependency. I feel the build dependencies should be strictly used only when necessary, and this particular subpackage doesn't seem to fit that criteria.The text was updated successfully, but these errors were encountered: