Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated Symmteric and Asymmetric Encryption Description #2139

Merged
merged 8 commits into from
Jul 12, 2022
Merged

Updated Symmteric and Asymmetric Encryption Description #2139

merged 8 commits into from
Jul 12, 2022

Conversation

dmagnate
Copy link
Contributor

@dmagnate dmagnate commented Jul 4, 2022

Thank you for submitting a Pull Request to the Mobile Security Testing Guide. Please make sure that:

  • Your contribution is written in the 2nd person (e.g. you)
  • Your contribution is written in an active present form for as much as possible.
  • You have made sure that the reference section is up to date (e.g. please add sources you have used, make sure that the references to MITRE/MASVS/etc. are up to date)
  • Your contribution has proper formatted markdown and/or code
  • Any references to website have been formatted as [TEXT](URL “NAME”)
  • You verified/tested the effectiveness of your contribution (e.g.: is the code really an effective remediation? Please verify it works!)

If your PR is related to an issue. Please end your PR test with the following line:
This PR closes #< insert number here >.

@dmagnate
Update 0x04g-Testing-Cryptography.md
63fcc2a 
Added description of Symmetric and Asymmetric encryption methods.
@dmagnate
Update 0x04g-Testing-Cryptography.md
9f054dc
TheDauntless
TheDauntless requested changes Jul 8, 2022
View reviewed changes
Copy link
Collaborator

@TheDauntless TheDauntless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing! 🥳

I've made a few additional modifications; can you please accept the proposed changes so that we can merge your contributions? :)

Document/0x04g-Testing-Cryptography.md Outdated Show resolved Hide resolved
Document/0x04g-Testing-Cryptography.md Outdated Show resolved Hide resolved
Document/0x04g-Testing-Cryptography.md Outdated Show resolved Hide resolved
Document/0x04g-Testing-Cryptography.md Outdated Show resolved Hide resolved
dmagnate and others added 4 commits July 9, 2022 11:06
@dmagnate @TheDauntless
Update Document/0x04g-Testing-Cryptography.md
7ff6fb3 
Co-authored-by: Jeroen Beckers <me.githbub@dauntless.be>
@dmagnate @TheDauntless
Update Document/0x04g-Testing-Cryptography.md
9904655 
Co-authored-by: Jeroen Beckers <me.githbub@dauntless.be>
@dmagnate @TheDauntless
Update Document/0x04g-Testing-Cryptography.md
86f6d8a 
Co-authored-by: Jeroen Beckers <me.githbub@dauntless.be>
@dmagnate @TheDauntless
Update Document/0x04g-Testing-Cryptography.md
04ee26c 
Co-authored-by: Jeroen Beckers <me.githbub@dauntless.be>
dmagnate
dmagnate commented Jul 9, 2022
View reviewed changes
Copy link
Contributor Author

@dmagnate dmagnate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review and update @TheDauntless

TheDauntless
TheDauntless approved these changes Jul 9, 2022
View reviewed changes
Copy link
Collaborator

@TheDauntless TheDauntless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

cpholguera
cpholguera approved these changes Jul 12, 2022
View reviewed changes
Copy link
Collaborator

@cpholguera cpholguera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @dmagnate!

Document/0x04g-Testing-Cryptography.md Outdated Show resolved Hide resolved
Document/0x04g-Testing-Cryptography.md Outdated Show resolved Hide resolved
@cpholguera cpholguera merged commit 737565b into OWASP:master Jul 12, 2022
@cpholguera cpholguera changed the title Updated Symmteric and Asymmetric encryption description Updated Symmteric and Asymmetric Encryption Description Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpholguera cpholguera cpholguera approved these changes

@TheDauntless TheDauntless TheDauntless approved these changes

Assignees
No one assigned
Labels
fundamentals MASVS-CRYPTO
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dmagnate @TheDauntless @cpholguera