Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve accessibility #406

Merged
merged 1 commit into from
Aug 16, 2022
Merged

improve accessibility #406

merged 1 commit into from
Aug 16, 2022

Conversation

tdtds
Copy link
Contributor

@tdtds tdtds commented Apr 30, 2021

I used NVDA to see if this site was available in audio only. The following improvements will allow you to use most of the site's features.

  • add aria-label into some elements without the label
  • add aria-label into some visual elements
  • replace some a elements have a button action to button

@tdtds
improve accessibility
27f02c2 
* add 'aria-label' into some elements without the label
* add 'aris-label' into some visual elements
* replace some 'a' elements have a button action to 'button'
cktricky
cktricky approved these changes Aug 16, 2022
View reviewed changes
Copy link
Contributor

@cktricky cktricky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and thank you @tdtds for making this more accessible.

@cktricky cktricky merged commit c1e8ff1 into OWASP:master Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cktricky cktricky cktricky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tdtds @cktricky