Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo does not bring back data flows #1069

Open
srcnuzn opened this issue Aug 22, 2024 · 7 comments
Open

Undo does not bring back data flows #1069

srcnuzn opened this issue Aug 22, 2024 · 7 comments
Labels
AntV/X6 bug Something isn't working version-2.4
Milestone

Comments

@srcnuzn
Copy link

srcnuzn commented Aug 22, 2024

Describe the bug:

Have two processes connected by data flow. When deleting the process, the data flows are deleted, too. When undoing the action, only the process is brought back. The data flows are gone.

Expected behaviour:

Undo should bring back all deleted elements.

Environment:

  • Version: 2.2
  • Platform: Desktop App
  • OS: Windows 11

To Reproduce:

  1. Create two processes
  2. Connect them with data flow
  3. Delete one process
  4. Click undo

Any additional context, screenshots, etc:

2024-08-22_13h25_21

@srcnuzn srcnuzn added the bug Something isn't working label Aug 22, 2024
@srcnuzn
Copy link
Author

srcnuzn commented Aug 22, 2024

I've almost lost a lot of my work. I accidentally deleted a process which has five data flows connected to it, each with multiple threats assigned to them. When deleting the process, all data flows and corresponding threats were gone! Fortunately, I had saved my model and I was able to reload it...

@jgadsden
Copy link
Collaborator

agreed, and this was a discussion in #640 that is now resolved in favour of the functionality in this bug report
we do not have a fix for this, it may be a feature of AntV/X6 that we can not get round, but planning this for version 2.4 in case it is possible

@srcnuzn
Copy link
Author

srcnuzn commented Aug 23, 2024

From all the bugs I've raised yesterday, I personally think this is the most critical one, especially because identified threats/mitigations and documentations are unintentionally, but permanently lost (with no undo possibility).

By the way, the unintentional deletion happened by accidentally clicking on the delete button (I wanted to select the node)
image

@lreading
Copy link
Collaborator

lreading commented Sep 13, 2024

I took a look at this and couldn't reproduce the issue... on linux. I was able to reproduce this on MacOS, and @srcnuzn reported this from Windows. I don't have a solution, but I just thought that was interesting and wanted to add here in case anyone picks this up. 😄

The bug might only be in electron. When using the web app on MacOS, it works as expected for me.

@jgadsden
Copy link
Collaborator

jgadsden commented Oct 6, 2024

I can not reproduce this myself - the undo works for both electron and web versions
I suggest we get the new drawing package merged into main (sometime this month) and then retest?

@jgadsden jgadsden self-assigned this Oct 6, 2024
@jgadsden jgadsden modified the milestones: Version 2.4, Version 2.3 Oct 6, 2024
@jgadsden
Copy link
Collaborator

@srcnuzn and @lreading could you retest this when you get a chance, using the latest version
I will bump this to version 2.4 for now

@jgadsden jgadsden modified the milestones: Version 2.3, Version 2.4 Oct 16, 2024
@jgadsden jgadsden removed their assignment Oct 16, 2024
@lreading
Copy link
Collaborator

Looking good on the main branch on ubuntu 24.04 and macOS sequoia!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AntV/X6 bug Something isn't working version-2.4
Projects
None yet
Development

No branches or pull requests

3 participants