Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two undo/redo methods do not join up #972

Open
jgadsden opened this issue Jun 3, 2024 · 0 comments
Open

Two undo/redo methods do not join up #972

jgadsden opened this issue Jun 3, 2024 · 0 comments
Labels
bug Something isn't working priority version-2.4
Milestone

Comments

@jgadsden
Copy link
Collaborator

jgadsden commented Jun 3, 2024

Describe the bug:
There is a pull down menu item which can undo/redo text
and there is also a undo/redo for the components on the diagram

Expected behaviour:
when redo/undo is selected from the pull down menu, if the drawing is in focus then the drawing package undo/redo buttons should be applied to the drawing components. If drawing component's attributes are changed then this should have redo/undo applied from the drawing package buttons

Environment:

  • Version: 2.x
  • Platform: Desktop App
  • OS: any
  • Browser: electron

To Reproduce:

  1. open a diagram in the desktop app
  2. observe undo/redo from within the drawing package for a component
  3. modify the name of the component, observe redo/undo from pull down
  4. use undo/redo from within the drawing package and observe node name changing, but not text box
  5. observe that pull down menu redo/undo does not apply to movement + changes to drawing components

Any additional context, screenshots, etc:

@jgadsden jgadsden added bug Something isn't working priority version-2.3 labels Jun 3, 2024
@jgadsden jgadsden added this to the Version 2.3 milestone Jun 3, 2024
@jgadsden jgadsden self-assigned this Aug 7, 2024
@jgadsden jgadsden modified the milestones: Version 2.3, Version 2.4 Oct 13, 2024
@jgadsden jgadsden removed their assignment Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority version-2.4
Projects
None yet
Development

No branches or pull requests

1 participant