-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP - Adds new JavaFX launcher #6770
Conversation
- Added boilerplate (from Stackoverflow) to Controller to help figure out launching OpenRefine as Service
- Added boilerplate (from Stackoverflow) to Controller to help figure out launching OpenRefine as Service
- also small improvements to graphic, layout, and added logo
- also small improvements to graphic, layout, and added logo
Currently translated at 100.0% (3 of 3 strings) Translation: OpenRefine/OpenRefine Messages Translate-URL: https://hosted.weblate.org/projects/openrefine/openrefine-messages/en_GB/
* Update dead links and copy edit Copy edit for consistency and more positive & welcoming tone (do this, not don't do that) * Address review comments
- Also added Confirm close dialog that calls process destroy that should hopefully terminate as CTRL-C did in terminal.
- Also added Confirm close dialog that calls process destroy that should hopefully terminate as CTRL-C did in terminal.
…e#6613 (OpenRefine#6755) Cherry picked from commit ba22493) and added tests Co-authored-by: Ansh Goel <127686105+dino2580@users.noreply.github.com> Co-authored-by: xinluz6 <156732707+xinluz6@users.noreply.github.com>
…OpenRefine#6771) * NPM is at version 10.8 currently, so this must be about node.js * Update to Node.js 18 to match Cypress requirement --------- Co-authored-by: Tom Morris <tfmorris@gmail.com>
Bumps the cypress group in /main/tests/cypress with 2 updates: [eslint](https://github.com/eslint/eslint) and [eslint-plugin-cypress](https://github.com/cypress-io/eslint-plugin-cypress). Updates `eslint` from 9.8.0 to 9.9.0 - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md) - [Commits](eslint/eslint@v9.8.0...v9.9.0) Updates `eslint-plugin-cypress` from 3.4.0 to 3.5.0 - [Release notes](https://github.com/cypress-io/eslint-plugin-cypress/releases) - [Commits](cypress-io/eslint-plugin-cypress@v3.4.0...v3.5.0) --- updated-dependencies: - dependency-name: eslint dependency-type: direct:development update-type: version-update:semver-minor dependency-group: cypress - dependency-name: eslint-plugin-cypress dependency-type: direct:development update-type: version-update:semver-minor dependency-group: cypress ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…6.0 (OpenRefine#6781) Bumps org.apache.commons:commons-lang3 from 3.15.0 to 3.16.0. --- updated-dependencies: - dependency-name: org.apache.commons:commons-lang3 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ine#6782) Bumps com.google.apis:google-api-services-sheets from v4-rev20240716-2.0.0 to v4-rev20240730-2.0.0. --- updated-dependencies: - dependency-name: com.google.apis:google-api-services-sheets dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps org.apache.commons:commons-compress from 1.26.2 to 1.27.0. --- updated-dependencies: - dependency-name: org.apache.commons:commons-compress dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ne#6784) Bumps com.google.apis:google-api-services-drive from v3-rev20240722-2.0.0 to v3-rev20240730-2.0.0. --- updated-dependencies: - dependency-name: com.google.apis:google-api-services-drive dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ne#6785) Bumps org.slf4j:slf4j-api from 2.0.13 to 2.0.16. --- updated-dependencies: - dependency-name: org.slf4j:slf4j-api dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ne#6786) Bumps [org.apache.maven.plugins:maven-gpg-plugin](https://github.com/apache/maven-gpg-plugin) from 3.2.4 to 3.2.5. - [Release notes](https://github.com/apache/maven-gpg-plugin/releases) - [Commits](apache/maven-gpg-plugin@maven-gpg-plugin-3.2.4...maven-gpg-plugin-3.2.5) --- updated-dependencies: - dependency-name: org.apache.maven.plugins:maven-gpg-plugin dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [org.codehaus.mojo:exec-maven-plugin](https://github.com/mojohaus/exec-maven-plugin) from 3.3.0 to 3.4.0. - [Release notes](https://github.com/mojohaus/exec-maven-plugin/releases) - [Commits](mojohaus/exec-maven-plugin@3.3.0...3.4.0) --- updated-dependencies: - dependency-name: org.codehaus.mojo:exec-maven-plugin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Remove JUnit from LevenshteinDistanceTests * Remove uses of JUnit and replace with TestNG A couple of modules still have the JUnit compatible shim for assertEquals to save the work of swapping parameter order.
* Switch to thread-safe DateTimeFormatter Fixes OpenRefine#6774.
- Added boilerplate (from Stackoverflow) to Controller to help figure out launching OpenRefine as Service
- Added boilerplate (from Stackoverflow) to Controller to help figure out launching OpenRefine as Service
- also small improvements to graphic, layout, and added logo
- also small improvements to graphic, layout, and added logo
- Also added Confirm close dialog that calls process destroy that should hopefully terminate as CTRL-C did in terminal.
- Also added Confirm close dialog that calls process destroy that should hopefully terminate as CTRL-C did in terminal.
Hi @tfmorris Any idea why I'm having so much difficulty on this PR with the linting and why it's so painful? Maybe because I am on Windows?
What shall I do ? Kill the PR and then perhaps push with a new one? I'm open to any suggestions to more easily remedy this. PS. I also have this in my global |
@thadguidry sorry I missed your earlier ping. Since I don't know anything about JavaFX, I hadn't even looked at this PR. The problem that you're running into was introduced back in 2018. I don't understand why the change was made, but I've created #6841 to fix it and put it back the way it was. With the current setup anyone attempting to develop on Windows is going to have great difficulty. |
Ok then I will force LF endings which actually should be our default since Windows IDEs can handle this now. I think most other open source projects do that. |
Moving to new branch and PR #6855 |
Fixes #3221
DRAFT - Work In Progress
TODO: