-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Ensure Go SDK compatibility with k8s CRDs #284
Comments
Depends on #283 |
This issue might be of interest to these efforts: #18 |
I've closed the previous issue on that: #87, but you might still find Ken's comments of value and relevance. |
Is the goal of OpenSLO to provide full, generated Kubernetes CRDs and enable usage purely as a library by Kubernetes Operators, or should usage look something like this: https://github.com/oskoperator/osko/pull/129/files#diff-c0681b1695b5f75b8093dc4fa7177e2d46bcc28236759831f84b582670fe2916R23 where the Kubernetes operator is still responsible for the fields mainly related to k8s and just uses the pure spec of OpenSLO? @nieomylnieja thoughts on this? |
@fourstepper Imo we should have generated objects of Kind Not everyone have to use kubebuilder as their tool for building an operators and not all of them have to be written in go. Providing CRDs is more flexible and open solution. |
I generally do agree with that, although it brings some more responsibility/maintenance to this repository (which however I think we agreed on before, though). I will continue with that in mind :) Note to self: Make sure that the CI checks that the CRDs have been generated to reflect latest changes in the code (aka probably by doing the generation in CI and checking if |
Proposal
To align with the Kubernetes ecosystem, it would be great if there were CRDs that defined the various parts of the specification.
The text was updated successfully, but these errors were encountered: