Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Ensure Go SDK compatibility with k8s CRDs #284

Open
fourstepper opened this issue Sep 24, 2024 · 6 comments · May be fixed by #292
Open

feat: Ensure Go SDK compatibility with k8s CRDs #284

fourstepper opened this issue Sep 24, 2024 · 6 comments · May be fixed by #292
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@fourstepper
Copy link
Collaborator

fourstepper commented Sep 24, 2024

Proposal

To align with the Kubernetes ecosystem, it would be great if there were CRDs that defined the various parts of the specification.

@fourstepper fourstepper self-assigned this Sep 24, 2024
@fourstepper fourstepper converted this from a draft issue Sep 24, 2024
@fourstepper
Copy link
Collaborator Author

Depends on #283

@fourstepper fourstepper changed the title feat: Integrate with k8s CRDs feat: Ensure Go SDK compatibility with k8s CRDs Sep 24, 2024
@fourstepper fourstepper added the enhancement New feature or request label Sep 24, 2024
@nieomylnieja
Copy link
Member

This issue might be of interest to these efforts: #18

@nieomylnieja
Copy link
Member

I've closed the previous issue on that: #87, but you might still find Ken's comments of value and relevance.

@fourstepper fourstepper linked a pull request Sep 30, 2024 that will close this issue
3 tasks
@fourstepper
Copy link
Collaborator Author

Is the goal of OpenSLO to provide full, generated Kubernetes CRDs and enable usage purely as a library by Kubernetes Operators, or should usage look something like this: https://github.com/oskoperator/osko/pull/129/files#diff-c0681b1695b5f75b8093dc4fa7177e2d46bcc28236759831f84b582670fe2916R23 where the Kubernetes operator is still responsible for the fields mainly related to k8s and just uses the pure spec of OpenSLO?

@nieomylnieja thoughts on this?

@fourstepper fourstepper added this to the v2 release milestone Oct 10, 2024
@fpiwowarczyk
Copy link
Member

@fourstepper Imo we should have generated objects of Kind CustomResourceDefinition so probably your first option.

Not everyone have to use kubebuilder as their tool for building an operators and not all of them have to be written in go. Providing CRDs is more flexible and open solution.

@fourstepper
Copy link
Collaborator Author

fourstepper commented Oct 17, 2024

I generally do agree with that, although it brings some more responsibility/maintenance to this repository (which however I think we agreed on before, though). I will continue with that in mind :)

Note to self: Make sure that the CI checks that the CRDs have been generated to reflect latest changes in the code (aka probably by doing the generation in CI and checking if git sees no changes)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging a pull request may close this issue.

3 participants