Proposal: Update the service field to serviceRef as it's a pointer to the Service Object #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nieomylnieja
requested changes
Sep 4, 2024
There was a problem hiding this comment.
While I personally agree, I'd wait for others to give their votes/perspective.
Meanwhile, since Go structs are already defined for v2alpha1, we need to update them too:
OpenSLO/pkg/openslo/v2alpha1/slo.go
Line 32 in 14f2119
7286794
to
098a9a3
Compare
098a9a3
to
0bd9ea6
Compare
nieomylnieja
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Within the OpenSLO spec we allow references to other objects, like
sliRef,dataSourceRef. These point to SLI and DataSource Objects.However the field name for the service is currently names
service, when it likely should be calledserviceRefas it's a pointer to the Service Object.