Make OpenSLO spec concrete #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would like to change this in the v1 as well. Doesn't break spec nor implementation (as discussed on the OpenSLO meeting) |
|
@fourstepper yup, this PR is about v1. |
fourstepper
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem statement
We claim that OpenSLO should be vendor agnostic, this means that spec should be running for different vendors without any additional changes. At least to the core, vendor specific annotations should be fine. With this bullet point there is possibility that the same spec won't work for two vendors although both of them clam that they support OpenSLO and they are right.
Another thing is that recently we decided that we want to make OpenSLO not only easy to use but also easy to implement as we want new projects to start using this spec. Taking specification concrete and simple is step into this direction.