-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Language worker "User" logs are ignored after execution is complete #8222
Comments
User logs - Cx have access to these logs via App Insights - are super set for Function Execution logs + Host / Extension logs - Any logs coming from Host are considered as system logs and can be logged to Kusto. User logs cannot be logged to Kusto as they are considered PII
Logs between invocation request and invocation complete should be considered user logs- logs after execution completes are orphaned logs
Host should not log from orphaned executions - but you bring up a good point specifically for errors - as of now we do not have a good solution for this. |
If the language worker is crafting the message itself, can't we consider it system logs regardless of when it happens? There's no risk of PII as long as it's a simple hard-coded string, which is why I assume it's okay for the host to write system logs during this time. Having those worker logs in our telemetry would be very helpful for supportability of language workers. |
If the error is coming from the worker itself, I would consider it a system log, especially if it doesn't include the user's actual function logs (which is the PII part). i.e. like Eric suggested, the worker is seeing some sort of error and is crafting a log for it |
This item requires design and we need to gather requirements for worker logs not associated with an invocation. Adding to the backlog for the design work. |
@AnatoliB it would be good to sync on this to make sure we're not duplicating anything you're already planning for this area. |
Back when @yojagad added a
LogCategory
for language workers to pass eitherSystem
orUser
in this PR to the node worker, @pragnagopa saidHowever, some of the logs in question are like this:
Which actually happens after execution completes. As of today, those logs are silently ignored by the host here (nothing in app insights, nothing in the console, etc.). Which leads me to a few questions:
System
andUser
logs? (We might want to document in the protobuf definition)cc @alrod
The text was updated successfully, but these errors were encountered: