Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove PATCH convenience methods on Azure.Communication.Jobrouter #29813

Merged
merged 3 commits into from
Jul 26, 2024
Merged

Remove PATCH convenience methods on Azure.Communication.Jobrouter #29813

merged 3 commits into from
Jul 26, 2024

Conversation

ArcturusZhang
Copy link
Member

Choose a PR Template

Switch to "Preview" on this description then select one of the choices below.

Click here to open a PR for a Data Plane API.

Click here to open a PR for a Control Plane (ARM) API.

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jul 15, 2024 •
edited
Loading

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jul 15, 2024 •
edited
Loading

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]
️🔄 azure-sdk-for-net-track2 inProgress [Detail]
️⚠️ azure-sdk-for-python warning [Detail]
    For more instructions, please refer to the FAQ .
  • ⚠️Warning in generating from dce1b726576d0b28e75950b20ac3f15834cdde21. SDK Automation 14.0.0 
    command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] W: Target Packages (main/binary-amd64/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target Packages (main/binary-all/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target Translations (main/i18n/Translation-en) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-amd64) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-all) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target Packages (main/binary-amd64/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target Packages (main/binary-all/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target Translations (main/i18n/Translation-en) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-amd64) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-all) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
  • ️✔️azure-communication-jobrouter [Preview SDK Changes] 
    info	[Changelog] data-plan skip changelog generation temporarily
️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
    For more instructions, please refer to the FAQ .
  • ️✔️Succeeded in generating from dce1b726576d0b28e75950b20ac3f15834cdde21. SDK Automation 14.0.0 
    command	./eng/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
  • ️✔️azure-communication-jobrouter [Preview SDK Changes] Breaking Change Detected
    Only showing 120 items here. Refer to log for details.
    info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
info	[Changelog] * `getKind()` was added
info	[Changelog]
info	[Changelog] #### `models.ExceptionPolicy` was modified
info	[Changelog]
info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
info	[Changelog]
info	[Changelog] #### `JobRouterAdministrationAsyncClient` was modified
info	[Changelog]
info	[Changelog] * `updateDistributionPolicy(java.lang.String,models.DistributionPolicy)` was added
info	[Changelog] * `updateQueue(java.lang.String,models.RouterQueue)` was added
info	[Changelog] * `updateExceptionPolicy(java.lang.String,models.ExceptionPolicy)` was added
info	[Changelog] * `updateClassificationPolicy(java.lang.String,models.ClassificationPolicy)` was added
info	[Changelog]
info	[Changelog] #### `models.RouterJobAssignment` was modified
info	[Changelog]
info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
info	[Changelog]
info	[Changelog] #### `JobRouterAdministrationClient` was modified
info	[Changelog]
info	[Changelog] * `updateQueue(java.lang.String,models.RouterQueue)` was added
info	[Changelog] * `updateClassificationPolicy(java.lang.String,models.ClassificationPolicy)` was added
info	[Changelog] * `updateDistributionPolicy(java.lang.String,models.DistributionPolicy)` was added
info	[Changelog] * `updateExceptionPolicy(java.lang.String,models.ExceptionPolicy)` was added
info	[Changelog]
info	[Changelog] #### `models.ExceptionRule` was modified
info	[Changelog]
info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
info	[Changelog] * `setTrigger(models.ExceptionTrigger)` was added
info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
info	[Changelog] * `setActions(java.util.List)` was added
info	[Changelog] * `setId(java.lang.String)` was added
info	[Changelog]
info	[Changelog] #### `models.JobMatchingMode` was modified
info	[Changelog]
info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
info	[Changelog]
info	[Changelog] #### `models.ConditionalQueueSelectorAttachment` was modified
info	[Changelog]
info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
info	[Changelog] * `getKind()` was added
info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
info	[Changelog] * `setQueueSelectors(java.util.List)` was added
info	[Changelog] * `setCondition(models.RouterRule)` was added
info	[Changelog]
info	[Changelog] #### `implementation.models.ReclassifyJobOptionsInternal` was modified
info	[Changelog]
info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
info	[Changelog]
info	[Changelog] #### `models.RouterJobNote` was modified
info	[Changelog]
info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
info	[Changelog] * `setMessage(java.lang.String)` was added
info	[Changelog]
info	[Changelog] #### `models.WorkerSelectorAttachment` was modified
info	[Changelog]
info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
info	[Changelog]
info	[Changelog] #### `JobRouterClient` was modified
info	[Changelog]
info	[Changelog] * `updateWorker(java.lang.String,models.RouterWorker)` was added
info	[Changelog] * `createJobWithClassificationPolicy(models.CreateJobWithClassificationPolicyOptions)` was added
info	[Changelog] * `createJobWithClassificationPolicyWithResponse(models.CreateJobWithClassificationPolicyOptions,com.azure.core.http.rest.RequestOptions)` was added
info	[Changelog] * `updateJob(java.lang.String,models.RouterJob)` was added
info	[Changelog]
info	[Changelog] #### `models.QueueSelectorAttachment` was modified
info	[Changelog]
info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
info	[Changelog]
info	[Changelog] #### `models.RuleEngineWorkerSelectorAttachment` was modified
info	[Changelog]
info	[Changelog] * `getKind()` was added
info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
info	[Changelog] * `setRule(models.RouterRule)` was added
info	[Changelog]
info	[Changelog] #### `models.ScheduleAndSuspendMode` was modified
info	[Changelog]
info	[Changelog] * `setScheduleAt(java.time.OffsetDateTime)` was added
info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
info	[Changelog] * `getKind()` was added
info	[Changelog]
info	[Changelog] #### `models.FunctionRouterRule` was modified
info	[Changelog]
info	[Changelog] * `getKind()` was added
info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
info	[Changelog] * `setFunctionUri(java.lang.String)` was added
info	[Changelog]
info	[Changelog] #### `models.RoundRobinMode` was modified
info	[Changelog]
info	[Changelog] * `getKind()` was added
info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
info	[Changelog]
info	[Changelog] #### `models.RouterRule` was modified
info	[Changelog]
info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
info	[Changelog]
info	[Changelog] #### `models.RouterJobPositionDetails` was modified
info	[Changelog]
info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
info	[Changelog]
info	[Changelog] #### `implementation.models.CancelJobResultInternal` was modified
info	[Changelog]
info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
info	[Changelog]
info	[Changelog]
    Parse Suppression File Errors
No suppression file added.
    Please refer to the guidance for suppressing SDK breaking changes.
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    For more instructions, please refer to the FAQ .
  • ️✔️Succeeded in generating from dce1b726576d0b28e75950b20ac3f15834cdde21. SDK Automation 14.0.0 
    command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	Warning: File azure-sdk-for-js_tmp/initOutput.json not found to read. Please re-run the pipeline if the error is transitient error or report this issue through https://aka.ms/azsdk/support/specreview-channel.
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
cmderr	[automation_generate.sh] [ERROR] Generate changelog failed: ENOENT: no such file or directory, open '/mnt/vss/_work/1/s/azure-sdk-for-js/sdk/communication/communication-job-router-rest/changelog-temp/package/review/rest/communication-job-router.api.md'
  • ️✔️@azure-rest/communication-job-router [Preview SDK Changes] 
    info	[Changelog]
error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jul 15, 2024 •
edited
Loading

Generated ApiView

Language Package Name ApiView Link
JavaScript @azure-rest/communication-job-router https://apiview.dev/Assemblies/Review/c803413a44f94ac19c189b18293736c8?revisionId=d252c768942a4070a7e3720f714293e4
Python azure-communication-jobrouter https://apiview.dev/Assemblies/Review/a0a3b623cd52438c8400f0748195e0bc?revisionId=91e382fe03364c4080d14f81c6ad3286
Java azure-communication-jobrouter There is no API change compared with the previous version
.Net Azure.Communication.JobRouter There is no API change compared with the previous version
TypeSpec Communication.JobRouter https://apiview.dev/Assemblies/Review/1b7d23f22666411187e8591316a4569c?revisionId=9f575025a5e9479099fec803721e7c5e

@AzureRestAPISpecReview AzureRestAPISpecReview added the TypeSpec Authored with TypeSpec label Jul 15, 2024
This was referenced Jul 15, 2024
Closed
Closed
Closed
@ArcturusZhang ArcturusZhang marked this pull request as ready for review July 25, 2024 15:34
@azure-sdk azure-sdk mentioned this pull request Jul 25, 2024
Closed
@ArcturusZhang ArcturusZhang merged commit b75726f into Azure:main Jul 26, 2024
29 of 30 checks passed
hmmorales pushed a commit that referenced this pull request Jul 31, 2024
@ArcturusZhang @hmmorales
Remove PATCH convenience methods on Azure.Communication.Jobrouter (#2…
1746331 
…9813)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@archerzz archerzz archerzz approved these changes

Assignees
No one assigned
Labels
TypeSpec Authored with TypeSpec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ArcturusZhang @archerzz @AzureRestAPISpecReview