Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix misalignment with service behavior around enum handling #30060

Merged
merged 10 commits into from
Aug 9, 2024
Merged

fix misalignment with service behavior around enum handling #30060

merged 10 commits into from
Aug 9, 2024

Conversation

wangyuantao
Copy link
Member

Choose a PR Template

Switch to "Preview" on this description then select one of the choices below.

Click here to open a PR for a Data Plane API.

Click here to open a PR for a Control Plane (ARM) API.

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Aug 1, 2024 •
edited
Loading

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This is the public specs repo main branch which is not intended for iterative development.
    You must acknowledge that you understand that after this PR is merged, you won't be able to stop your changes from being published to Azure customers.
    If this is what you intend, add PublishToCustomers label to your PR.
    Otherwise, retarget this PR onto a feature branch, i.e. with prefix release- (see aka.ms/azsdk/api-versions#release--branches).
  • ❌ This PR has at least one change violating Azure versioning policy (label: VersioningReviewRequired).
    To unblock this PR, either a) introduce a new API version with these changes instead of modifying an existing API version, or b) follow the process at aka.ms/brch.
  • ❌ The required check named Automated merging requirements met has failed. This is the final check that must pass. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide. In addition, refer to step 4 in the PR workflow diagram

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Aug 1, 2024 •
edited
Loading

Generated ApiView

Language Package Name ApiView Link
Swagger AzureOpenAI https://apiview.dev/Assemblies/Review/6693675ace534d4aa3159f202a195962?revisionId=dfe22a1b60bf4c8281d1581aaa20d4de

@AzureRestAPISpecReview AzureRestAPISpecReview added data-plane VersioningReviewRequired <valid label in PR review process>add this label when versioning review is required labels Aug 1, 2024
@johanste johanste added the BreakingChange-Approved-BugFix Changes are to correct the REST API definition to correctly describe service behavior label Aug 2, 2024
@lmazuel lmazuel merged commit 956bf8c into Azure:main Aug 9, 2024
27 of 30 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johanste johanste johanste approved these changes

@yangyuan yangyuan Awaiting requested review from yangyuan yangyuan is a code owner

Assignees
No one assigned
Labels
BreakingChange-Approved-BugFix Changes are to correct the REST API definition to correctly describe service behavior Cognitive Services data-plane VersioningReviewRequired <valid label in PR review process>add this label when versioning review is required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wangyuantao @johanste @lmazuel @AzureRestAPISpecReview