Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure-AsyncOperation poller can mistakenly fail in some cases #23321

Closed
jhendrixMSFT opened this issue Aug 13, 2024 · 2 comments
Closed

Azure-AsyncOperation poller can mistakenly fail in some cases #23321

jhendrixMSFT opened this issue Aug 13, 2024 · 2 comments
Assignees
@jhendrixMSFT
Labels
Azure.Core

Comments

@jhendrixMSFT
Copy link
Member

jhendrixMSFT commented Aug 13, 2024 •
edited
Loading

The async poller assumes that for PATCH/PUT that it's a RELO LRO thus can GET the original request URL for the final state.

https://github.com/Azure/azure-sdk-for-go/blob/main/sdk/azcore/internal/pollers/async/async.go#L131-L134

This might not be true in some cases like proxy resources. In these cases, we should honor the final-state-via setting.
@jhendrixMSFT jhendrixMSFT self-assigned this Aug 13, 2024
@jhendrixMSFT
Copy link
Member Author

See also #19889 which is related.

@jhendrixMSFT
Copy link
Member Author

Per discussion, final-state-via is for POST only. The docs have been updated, see Azure/autorest#5004.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhendrixMSFT jhendrixMSFT

Labels
Azure.Core
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jhendrixMSFT