Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace copies of RuntimeConfig with RuntimeConfigProvider #2321

Closed
aaronburtle opened this issue Aug 9, 2024 · 2 comments · Fixed by #2337
Closed

Replace copies of RuntimeConfig with RuntimeConfigProvider #2321

aaronburtle opened this issue Aug 9, 2024 · 2 comments · Fixed by #2337
Assignees
@aaronburtle
Labels
🔥Hot Reload Tasks related to DAB's Hot Reload feature proposal refactor
Milestone
1.3

Comments

@aaronburtle
Copy link
Contributor

aaronburtle commented Aug 9, 2024 •
edited
Loading

There are classes we currently use, such as the SqlMetaDataProvider, OpenApiDocumentor, and CostmosSqlMetaDataProvider, that save internal copies of the RuntimeConfig. These classes instead should have a copy of the RuntimeConfigProvider, and when a runtimeconfig is needed they should instead get that runtimeconfig from the provider as needed. This will cause the runtimeconfig to always be the most up to date copy.
@aaronburtle aaronburtle added this to the 1.3 milestone Aug 9, 2024
@aaronburtle aaronburtle self-assigned this Aug 9, 2024
@seantleonard
Copy link
Contributor

@aaronburtle the design doc is not publicly accessible. Doesn't need to be referenced here unless you end up created a markdown file to include in this repo

@aaronburtle
Copy link
Contributor Author

@aaronburtle the design doc is not publicly accessible. Doesn't need to be referenced here unless you end up created a markdown file to include in this repo

thanks for pointing that out Sean, ill remove from these issues.

@aaronburtle aaronburtle mentioned this issue Aug 15, 2024
Merged
@aaronburtle aaronburtle added the 🔥Hot Reload Tasks related to DAB's Hot Reload feature proposal label Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aaronburtle aaronburtle

Labels
🔥Hot Reload Tasks related to DAB's Hot Reload feature proposal refactor
Projects
None yet
Milestone
1.3
2 participants
@seantleonard @aaronburtle