Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hot-Reload Authorization rules #2324

Open
aaronburtle opened this issue Aug 9, 2024 · 1 comment · May be fixed by #2425
Open

Hot-Reload Authorization rules #2324

aaronburtle opened this issue Aug 9, 2024 · 1 comment · May be fixed by #2425
Assignees
Labels
enhancement New feature or request graphql 🔥Hot Reload Tasks related to DAB's Hot Reload feature proposal
Milestone

Comments

@aaronburtle
Copy link
Contributor

aaronburtle commented Aug 9, 2024

While we currently deserialize the new entities into our object mapping that makes up the runtimeconfig, we do not update the GraphQL Schema. For entities to properly hot-reload, we need the GraphQL Schema to update as new entities are added or old entities are removed.

We also do not currently refresh the AuthorizationResolver. This too needs to be refreshed to reflect the new authorization configuration as it is in the newly hot-reloaded entity section.

@aaronburtle aaronburtle added enhancement New feature or request graphql labels Aug 9, 2024
@aaronburtle aaronburtle added this to the 1.3 milestone Aug 9, 2024
@aaronburtle aaronburtle self-assigned this Aug 9, 2024
@aaronburtle aaronburtle changed the title Hot-Reload Entities and refresh GraphQL Schema Hot-Reload Entities and refresh GraphQL Schema and Authorization Aug 9, 2024
@aaronburtle aaronburtle added the 🔥Hot Reload Tasks related to DAB's Hot Reload feature proposal label Aug 30, 2024
@seantleonard seantleonard linked a pull request Oct 14, 2024 that will close this issue
2 tasks
@seantleonard seantleonard changed the title Hot-Reload Entities and refresh GraphQL Schema and Authorization Hot-Reload Authorization rules Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request graphql 🔥Hot Reload Tasks related to DAB's Hot Reload feature proposal
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants