Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new code page 1047 #531

Closed
sree018 opened this issue Nov 17, 2022 · 3 comments
Closed

new code page 1047 #531

sree018 opened this issue Nov 17, 2022 · 3 comments
Assignees
@yruslan
Labels
accepted Accepted for implementation enhancement New feature or request

Comments

@sree018
Copy link

sree018 commented Nov 17, 2022

Hi @yruslan

Can you support code page 1047 for Latin characters in future releases?

https://zims-en.kiwix.campusafrica.gos.orange.com/wikipedia_en_all_nopic/A/EBCDIC_1047
@sree018 sree018 added the question Further information is requested label Nov 17, 2022
@yruslan
Copy link
Collaborator

yruslan commented Nov 21, 2022

Hi @sree018, sorry for the delayed response. Yes, we will add the support. Thanks for the documentation! It makes it much easier to do.

@yruslan yruslan self-assigned this Nov 21, 2022
@yruslan yruslan added enhancement New feature or request accepted Accepted for implementation and removed question Further information is requested labels Nov 23, 2022
yruslan added a commit that referenced this issue Nov 23, 2022
@yruslan
#531 Add support for CP1047
cc78024 
https://zims-en.kiwix.campusafrica.gos.orange.com/wikipedia_en_all_nopic/A/EBCDIC_1047
yruslan added a commit that referenced this issue Nov 23, 2022
@yruslan
#531 Add support for CP1047
07b7429 
https://zims-en.kiwix.campusafrica.gos.orange.com/wikipedia_en_all_nopic/A/EBCDIC_1047
yruslan added a commit that referenced this issue Nov 23, 2022
@yruslan
#531 Add support for CP1047
72a8c56 
https://zims-en.kiwix.campusafrica.gos.orange.com/wikipedia_en_all_nopic/A/EBCDIC_1047
@yruslan
Copy link
Collaborator

yruslan commented Nov 23, 2022

@sree018 , this is implemented in the current master. Please, check and let me know if it worked for you.

@yruslan
Copy link
Collaborator

yruslan commented Nov 23, 2022

You can build the project from source using sbt: https://github.com/AbsaOSS/cobrix#creating-an-uber-jar

Or wait for new version of Cobrix to be released.
I'd prefer you check it from source first. This way if the change does not work as expected, it would be easier to fix.

@yruslan yruslan closed this as completed Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yruslan yruslan

Labels
accepted Accepted for implementation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yruslan @sree018