Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate values on lost focus instead of immediately / Typing in floats is difficult and using - characters can throw up errors. #14

Open
krypto5863 opened this issue Dec 30, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@krypto5863
Copy link

krypto5863 commented Dec 30, 2020

ConfigurationManager seems to really dislike it when you try to type in 0 after values higher than 0 in a decimal position. It also seems to really dislike typing in zeros before them in whole number places. Makes the configurations kinda wonky to use.

Also, trying to type a - sign anywhere but the start of the number throws up a good chunk of red in the console.

Hope this is fixed, configmanager is really handy for development...

@ManlyMarco
Copy link
Member

This is because the input is validated after every key press to make development easier. I didn't bother to improve it since most of the time the slider is used (you need to specify value range to make it show up though). To fix this the input would have to be validated after focus is lost.

@krypto5863
Copy link
Author

So after pressing enter or clicking another box? I'd personally prefer this implementation. Apply changes when changes are complete and all that.

@ManlyMarco ManlyMarco changed the title Typing in floats is difficult and using - characters can throw up errors. Validate values on lost focus instead of immediately / Typing in floats is difficult and using - characters can throw up errors. Dec 24, 2022
@ManlyMarco ManlyMarco added the enhancement New feature or request label Dec 24, 2022
@Californ1a
Copy link

Californ1a commented Apr 16, 2024

I was also looking to see if this was an option - right now all string configs kind of need a debounce timer added to them to prevent them from firing off with every letter the user types into the config. It would be very useful if there were two separate events similar to html's change event and input event so you would have the option of both/either live events and/or a single final event.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants