Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(critical): add critical severity to all report formats #6866

Merged
merged 111 commits into from
Mar 15, 2024
Merged

feat(critical): add critical severity to all report formats #6866

merged 111 commits into from
Mar 15, 2024

Conversation

ArturRibeiro-CX
Copy link
Contributor

Proposed Changes

  • add critical severity to all report formats.

I submit this contribution under the Apache-2.0 license.

@github-actions github-actions bot added the feature New feature label Feb 1, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 1, 2024 •
edited
Loading

kics-logo

KICS version: v1.7.13

Category Results
HIGH HIGH 0
MEDIUM MEDIUM 0
LOW LOW 0
INFO INFO 0
TRACE TRACE 0
TOTAL TOTAL 0
Metric Values
Files scanned placeholder 1
Files parsed placeholder 1
Files failed to scan placeholder 0
Total executed queries placeholder 49
Queries failed to execute placeholder 0
Execution time placeholder 1

@ArturRibeiro-CX
add critical to all result-reportformat.json files
8fedeb8
@ArturRibeiro-CX
fix pdf total vulnerabilities count, add html critical image
08862c2
@ArturRibeiro-CX
add some unit test for new critical severity in codeclimate and csv
c50990c
@ArturRibeiro-CX
more tests added
8b0a8c5
@ArturRibeiro-CX
added test for codeclimate format
6c1270d
@ArturRibeiro-CX
Revert "added test for codeclimate format"
fb03f63 
This reverts commit 6c1270d.
@ArturRibeiro-CX
Reapply "added test for codeclimate format"
1cbd5ed 
This reverts commit fb03f63.
@ArturRibeiro-CX
Revert "Reapply "added test for codeclimate format as it was the wron…
81a376f 
…g file""

This reverts commit 1cbd5ed.
@ArturRibeiro-CX
add real test to codeclimate, error in last commit
5e7ce81
@ArturRibeiro-CX
add e2e for all report formats with critical severity
ff7a1dc
@ArturRibeiro-CX
fix test critical custom queries
4a30b67
@ArturRibeiro-CX
change helpers to align with changes made to critical test custom que…
9d46de4 
…ries
@ArturRibeiro-CX
addition of unit test for sonarqube report format
99e7066
@ArturRibeiro-CX
fixed some issues related to later changes
231582c
@ArturRibeiro-CX
addition of a new criticalSummaryMock for exclusive testing
d8f70ed
@ArturRibeiro-CX
fix paths csv and codeclimate testing
d42fba3
@ArturRibeiro-CX
change to color red
462c7da
@ArturRibeiro-CX
add test for cyclonedx and comment to helpers
b513953
@ArturRibeiro-CX
fix linting problem on comment
47d7f47
@ArturRibeiro-CX
unit test addition to asff and cycloneDX reports
7ebc7fb
@ArturRibeiro-CX
fix unit tests
da2f455
@ArturRibeiro-CX
Merge branch 'master' into critical_add_reports
33486ad
@ArturRibeiro-CX
add critical to original enum asff
0f65b12
@ArturRibeiro-CX
cyclone_test change to pass SHA error
4cba580
@ArturRibeiro-CX
cyclone_test change to pass SHA error
1345534
@ArturRibeiro-CX
fix path error in helpers
3e51ebb
@ArturRibeiro-CX
fix paths to linux and windows
448c28f
pereiramarco011
pereiramarco011 previously approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@pereiramarco011 pereiramarco011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😄

gabriel-cx
gabriel-cx previously approved these changes Mar 13, 2024
View reviewed changes
gabriel-cx
gabriel-cx previously approved these changes Mar 13, 2024
View reviewed changes
@asofsilva asofsilva merged commit 5fa83a3 into master Mar 15, 2024
22 checks passed
@asofsilva asofsilva deleted the critical_add_reports branch March 15, 2024 14:44
@BrewTestBot BrewTestBot mentioned this pull request Apr 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pereiramarco011 pereiramarco011 pereiramarco011 approved these changes

@gabriel-cx gabriel-cx gabriel-cx left review comments

Assignees
No one assigned
Labels
feature New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ArturRibeiro-CX @gabriel-cx @pereiramarco011 @asofsilva @JoaoAtGit