Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(query): add new query for tencentcloud CVM resource #7136

Merged
merged 2 commits into from
Jun 18, 2024
Merged

feat(query): add new query for tencentcloud CVM resource #7136

merged 2 commits into from
Jun 18, 2024

Conversation

SevenEarth
Copy link

Hello, There is something new query for TencentCloud TKE resource:

cvm_instance_using_user_data

Please help review the PR
Thanks

I submit this contribution under the Apache-2.0 license.

@SevenEarth SevenEarth requested a review from a team as a code owner June 14, 2024 14:22
@github-actions github-actions bot added community Community contribution query New query feature labels Jun 14, 2024
@SevenEarth SevenEarth changed the title eat(query): add new query for tencentcloud CVM resource feat(query): add new query for tencentcloud CVM resource Jun 14, 2024
@github-actions github-actions bot added the feature request Community: new feature request label Jun 14, 2024
@SevenEarth
Copy link
Author

This is my local test
image

@SevenEarth
Copy link
Author

Hello
Please help review the PR
Thanks

ArturRibeiro-CX
ArturRibeiro-CX requested changes Jun 17, 2024
View reviewed changes
Copy link
Contributor

@ArturRibeiro-CX ArturRibeiro-CX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me but could we also add positive expected results for "secretId" and "secretKey" since the regex is also looking for those values?
Thanks for your contribution!

@ArturRibeiro-CX ArturRibeiro-CX merged commit 6435ca5 into Checkmarx:master Jun 18, 2024
27 checks passed
@SevenEarth
Copy link
Author

Looks good to me but could we also add positive expected results for "secretId" and "secretKey" since the regex is also looking for those values? Thanks for your contribution!

Yes, you are right. I will improve it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArturRibeiro-CX ArturRibeiro-CX ArturRibeiro-CX approved these changes

Assignees
No one assigned
Labels
community Community contribution feature request Community: new feature request query New query feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SevenEarth @ArturRibeiro-CX