Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update(workflow): add pattern validation for query name and description #7208

Merged
merged 65 commits into from
Aug 5, 2024
Merged

update(workflow): add pattern validation for query name and description #7208

merged 65 commits into from
Aug 5, 2024

Conversation

JulioSCX
Copy link
Contributor

Reason for Proposed Changes

  • To ensure query names and descriptions are consistently formatted.

Proposed Changes

  • Add query name and query description validation

I submit this contribution under the Apache-2.0 license.

@github-actions github-actions bot added the query New query feature label Jul 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 23, 2024 •
edited
Loading

kics-logo

KICS version: v2.1.1

Category Results
CRITICAL CRITICAL 0
HIGH HIGH 0
MEDIUM MEDIUM 0
LOW LOW 0
INFO INFO 0
TRACE TRACE 0
TOTAL TOTAL 0
Metric Values
Files scanned placeholder 1
Files parsed placeholder 1
Files failed to scan placeholder 0
Total executed queries placeholder 48
Queries failed to execute placeholder 0
Execution time placeholder 0

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 24, 2024 •
edited
Loading

Logo
Checkmarx One – Scan Summary & Details – 10f8e3f9-b033-40a0-8ecc-86f0947e3f1e

Fixed Issues

Severity Issue Source File / Package
HIGH CVE-2024-41110 Go-github.com/docker/docker-v25.0.5

@JulioSCX JulioSCX marked this pull request as ready for review July 26, 2024 17:09
@JulioSCX JulioSCX requested a review from a team as a code owner July 26, 2024 17:09
@JulioSCX
added back tests and reverted output results changes
b9948da
@JulioSCX
changed back to root chainguard
653a814
@JulioSCX
removed test
e8c964f
@JulioSCX
testing 041
b950bec
@JulioSCX
Merge branch 'add-pattern-validation-workflow' of https://github.com/…
bb26a4b 
…Checkmarx/kics into add-pattern-validation-workflow
@JulioSCX
Merge branch 'add-pattern-validation-workflow' of https://github.com/…
05d3a5d 
…Checkmarx/kics into add-pattern-validation-workflow
@JulioSCX
restore 041
bb75d7c
@JulioSCX
Merge branch 'add-pattern-validation-workflow' of https://github.com/…
355fad9 
…Checkmarx/kics into add-pattern-validation-workflow
@JulioSCX
restore file
f92c258
@JulioSCX
restore file
227d703
@JulioSCX
removed results file
0c22c0d
@JulioSCX
restore all tests
3fa5375
@JulioSCX
apk add sed
15d9c35
@JulioSCX
sed version
969b90c
@JulioSCX
apk update
5b0e731
@JulioSCX
remove sed version
e1deb7b
@JulioSCX
test git latest-dev
7b05207
@JulioSCX
removed tests
bf85b1d
@JulioSCX
added back results json
ad4df77
@JulioSCX
added back all tests
f10b074
@amacedoo
Copy link

@JulioSCX, for now you can use the dev image from chainguard till we have a proper solution to tackle the tests. This must be reviewed in our monthly meetings.

EduardoSemanas
EduardoSemanas approved these changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@EduardoSemanas EduardoSemanas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JulioSCX JulioSCX merged commit c9d374d into master Aug 5, 2024
27 checks passed
@JulioSCX JulioSCX deleted the add-pattern-validation-workflow branch August 5, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EduardoSemanas EduardoSemanas EduardoSemanas approved these changes

Assignees
No one assigned
Labels
query New query feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JulioSCX @amacedoo @EduardoSemanas