-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gallery missing in-app sample source code #230
Gallery missing in-app sample source code #230
Comments
I tested 3 variants of the app locally.
They're all working. @michael-hawker I'm not sure what happened, but it might actually be machine specific. Maybe a git clean was needed or something. |
@Arlodotexe today i compiled WinUI 3 Gallery source code, and i saw this issue there. I think they are related |
Thanks for this information, that'd be pretty odd as our gallery app in the store is a UWP app, so think that may just be a coincedence? I reinstalled our initial release build from Thursday 8/31 and it worked as expected (outside of the other issues we discovered and started fixing). Diff of those changes is here: 9c4749f...main There shouldn't be too much functional in here though, but just starting to take a look. |
Yeah, looking through the changes in the commits and the tooling, its mostly just doc/content changes, very minor. Nothing that should effect sample loading from my understanding. Guess next step is for me to retry building the app and see what happens... Wonder if I should backport the fixes I made while importing the docs repo first... 🤔 |
This is now fixed in the Store, if you go to settings you should see version 8.0.2 of the Sample App. I need to cherry-pick the commit from another branch to check-in. Had to do with code we had to strip some headers from the samples being displayed. Since it dealt with newlines it seemed like it had different behavior across files based on formatting from the repo/git/machine, etc... |
There's a known issue with the sample app not displaying XAML/C# code correctly for some reason, we think it's a build authoring issue, but not sure, we're still investigating. Please bear with us!
Originally posted by @michael-hawker in #228 (comment)
The text was updated successfully, but these errors were encountered: