Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problems with InternalsVisibleTo #441

Open
Arlodotexe opened this issue Jun 27, 2024 · 1 comment · May be fixed by #446
Open

Problems with InternalsVisibleTo #441

Arlodotexe opened this issue Jun 27, 2024 · 1 comment · May be fixed by #446

Comments

@Arlodotexe
Copy link
Member

Worth noting our use of InternalsVisibleTo are using or being used by same set of components that keep appearing in these issues-- Behaviors, Animations, Media and Extensions.

If our use of InternalsVisibleTo is indeed related to our AoT issues on Wasdk as well as what we've seen here regarding transient dependencies, it might be highlighting a deeper issue with how we've set up these libraries.

We might want to go through and see if we can remove the need for these InternalsVisibleTo, it looks like at least a few are just to avoid helper duplication. If it fixes any of the issues we've listed throughout this ticket, we've narrowed the scope of our search down considerably.

Originally posted by @Arlodotexe in #169 (comment)
This was referenced Jun 27, 2024
Draft
Open
@Arlodotexe
Copy link
Member Author

Arlodotexe commented Jul 2, 2024 •
edited
Loading

Adding additional details highlighted in #446:

We're testing these changes for three reasons:

The third reason is dismissed, CommunityToolkit/Tooling-Windows-Submodule#195 (comment) helped us verify that it was unrelated, and the fix offered by Mano and yourself @Sergio0694 double confirms that.

The first two are still a possible concern. If we can verify that the use of InternalsVisibleTo here isn't uncovering some platform bug causing #169, we can dismiss that as well and close this PR without merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Toolkit 8.x
Status: 🏗 In progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removed usage of InternalsVisibleTo in all components CommunityToolkit/Windows
1 participant
@Arlodotexe