Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port and add samples for Media EffectAnimations #151

Merged
merged 26 commits into from
Aug 21, 2023
Merged

Port and add samples for Media EffectAnimations #151

merged 26 commits into from
Aug 21, 2023

Conversation

Arlodotexe
Copy link
Member

@Arlodotexe Arlodotexe commented Jul 18, 2023 •
edited
Loading

This PR closes #124 by porting all existing samples for the Media package from the existing sample app. I've also added new samples for the EffectAnimations that didn't have them.

Opened as a draft PR as the OpacityEffectAnimation is not functional. Pending information from @Sergio0694.

Needs CommunityToolkit/Tooling-Windows-Submodule#102

@Arlodotexe Arlodotexe added enhancement New feature or request sample app 🖼️ labels Jul 18, 2023
@Arlodotexe Arlodotexe self-assigned this Jul 18, 2023
@michael-hawker
Copy link
Member

FYI @Arlodotexe

         D:\a\Windows\Windows\components\Media\samples\EffectAnimationsSampleOptions.xaml.cs(10,2): error CS0579: Duplicate 'ToolkitSampleOptionsPane' attribute [D:\a\Windows\Windows\components\Media\samples\Media.Samples.csproj]
         D:\a\Windows\Windows\components\Media\samples\EffectAnimationsSampleOptions.xaml.cs(11,2): error CS0579: Duplicate 'ToolkitSampleOptionsPane' attribute [D:\a\Windows\Windows\components\Media\samples\Media.Samples.csproj]
         D:\a\Windows\Windows\components\Media\samples\EffectAnimationsSampleOptions.xaml.cs(12,2): error CS0579: Duplicate 'ToolkitSampleOptionsPane' attribute [D:\a\Windows\Windows\components\Media\samples\Media.Samples.csproj]
         D:\a\Windows\Windows\components\Media\samples\EffectAnimationsSampleOptions.xaml.cs(13,2): error CS0579: Duplicate 'ToolkitSampleOptionsPane' attribute [D:\a\Windows\Windows\components\Media\samples\Media.Samples.csproj]
         D:\a\Windows\Windows\components\Media\samples\EffectAnimationsSampleOptions.xaml.cs(14,2): error CS0579: Duplicate 'ToolkitSampleOptionsPane' attribute [D:\a\Windows\Windows\components\Media\samples\Media.Samples.csproj]
         D:\a\Windows\Windows\components\Media\samples\EffectAnimationsSampleOptions.xaml.cs(15,2): error CS0579: Duplicate 'ToolkitSampleOptionsPane' attribute [D:\a\Windows\Windows\components\Media\samples\Media.Samples.csproj]
         D:\a\Windows\Windows\components\Media\samples\EffectAnimationsSampleOptions.xaml.cs(16,2): error CS0579: Duplicate 'ToolkitSampleOptionsPane' attribute [D:\a\Windows\Windows\components\Media\samples\Media.Samples.csproj]
         D:\a\Windows\Windows\components\Media\samples\EffectAnimationsSampleOptions.xaml.cs(17,2): error CS0579: Duplicate 'ToolkitSampleOptionsPane' attribute [D:\a\Windows\Windows\components\Media\samples\Media.Samples.csproj]

@Arlodotexe Arlodotexe mentioned this pull request Jul 18, 2023
Merged
@Arlodotexe
Copy link
Member Author

Arlodotexe commented Jul 18, 2023 •
edited
Loading

FYI @Arlodotexe

         D:\a\Windows\Windows\components\Media\samples\EffectAnimationsSampleOptions.xaml.cs(10,2): error CS0579: Duplicate 'ToolkitSampleOptionsPane' attribute [D:\a\Windows\Windows\components\Media\samples\Media.Samples.csproj]
         D:\a\Windows\Windows\components\Media\samples\EffectAnimationsSampleOptions.xaml.cs(11,2): error CS0579: Duplicate 'ToolkitSampleOptionsPane' attribute [D:\a\Windows\Windows\components\Media\samples\Media.Samples.csproj]
         D:\a\Windows\Windows\components\Media\samples\EffectAnimationsSampleOptions.xaml.cs(12,2): error CS0579: Duplicate 'ToolkitSampleOptionsPane' attribute [D:\a\Windows\Windows\components\Media\samples\Media.Samples.csproj]
         D:\a\Windows\Windows\components\Media\samples\EffectAnimationsSampleOptions.xaml.cs(13,2): error CS0579: Duplicate 'ToolkitSampleOptionsPane' attribute [D:\a\Windows\Windows\components\Media\samples\Media.Samples.csproj]
         D:\a\Windows\Windows\components\Media\samples\EffectAnimationsSampleOptions.xaml.cs(14,2): error CS0579: Duplicate 'ToolkitSampleOptionsPane' attribute [D:\a\Windows\Windows\components\Media\samples\Media.Samples.csproj]
         D:\a\Windows\Windows\components\Media\samples\EffectAnimationsSampleOptions.xaml.cs(15,2): error CS0579: Duplicate 'ToolkitSampleOptionsPane' attribute [D:\a\Windows\Windows\components\Media\samples\Media.Samples.csproj]
         D:\a\Windows\Windows\components\Media\samples\EffectAnimationsSampleOptions.xaml.cs(16,2): error CS0579: Duplicate 'ToolkitSampleOptionsPane' attribute [D:\a\Windows\Windows\components\Media\samples\Media.Samples.csproj]
         D:\a\Windows\Windows\components\Media\samples\EffectAnimationsSampleOptions.xaml.cs(17,2): error CS0579: Duplicate 'ToolkitSampleOptionsPane' attribute [D:\a\Windows\Windows\components\Media\samples\Media.Samples.csproj]

@michael-hawker Needs CommunityToolkit/Tooling-Windows-Submodule#102

@Arlodotexe Arlodotexe marked this pull request as ready for review July 25, 2023 16:41
@Arlodotexe Arlodotexe enabled auto-merge (rebase) August 4, 2023 22:12
@niels9001
Copy link
Collaborator

niels9001 commented Aug 18, 2023 •
edited
Loading

@Arlodotexe I'm gettting at runtime upon launch on WASDK:

Attempt by method 'CommunityToolkit.WinUI.Media.Pipelines.PipelineBuilder..ctor(System.Func1<System.Threading.Tasks.ValueTask1<Microsoft.UI.Composition.CompositionBrush>>)' to access method 'CommunityToolkit.WinUI.Animations.GuidExtensions.ToUppercaseAsciiLetters(System.Guid ByRef)' failed.

@niels9001
Copy link
Collaborator

niels9001 commented Aug 18, 2023 •
edited
Loading

@Arlodotexe tested via UWP sample app, works great! I'll push some (minor) design tweaks (e.g. adding icon) and then merge!

@niels9001 niels9001 merged commit 24d0559 into main Aug 21, 2023
7 checks passed
@delete-merged-branch delete-merged-branch bot deleted the component/media/samples branch August 21, 2023 16:03
@Arlodotexe Arlodotexe mentioned this pull request May 21, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niels9001 niels9001 niels9001 approved these changes

@Sergio0694 Sergio0694 Awaiting requested review from Sergio0694

@michael-hawker michael-hawker Awaiting requested review from michael-hawker

Assignees

@Arlodotexe Arlodotexe

Labels
enhancement New feature or request sample app 🖼️
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve Samples in Media
3 participants
@Arlodotexe @michael-hawker @niels9001