Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated tooling to latest version #160

Merged
merged 4 commits into from
Jul 25, 2023
Merged

Updated tooling to latest version #160

merged 4 commits into from
Jul 25, 2023

Conversation

Arlodotexe
Copy link
Member

@Arlodotexe Arlodotexe commented Jul 25, 2023 •
edited
Loading

In a dedicated PR to catch potential build errors.

@Arlodotexe Arlodotexe added bug Something isn't working dev loop ➰ regression What was working is now broke labels Jul 25, 2023
@Arlodotexe Arlodotexe self-assigned this Jul 25, 2023
@michael-hawker
Copy link
Member

This is the error buried in the WinUI 3 log:

2023-07-25T20:59:07.3697492Z        "D:\a\Windows\Windows\CommunityToolkit.AllComponents.sln" (default target) (1:2) ->
2023-07-25T20:59:07.3698402Z        "D:\a\Windows\Windows\tooling\ProjectHeads\AllComponents\WinAppSdk\CommunityToolkit.App.WinAppSdk.csproj" (default target) (50:6) ->
2023-07-25T20:59:07.3699212Z        (CoreCompile target) -> 
2023-07-25T20:59:07.3700419Z          D:\a\Windows\Windows\tooling\CommunityToolkit.App.Shared\Controls\TitleBar\NativeMethods.cs(13,22): error CA1060: Move pinvokes to native methods class [D:\a\Windows\Windows\tooling\ProjectHeads\AllComponents\WinAppSdk\CommunityToolkit.App.WinAppSdk.csproj]
2023-07-25T20:59:07.3701554Z 
2023-07-25T20:59:07.3701761Z     28 Warning(s)
2023-07-25T20:59:07.3702057Z     1 Error(s)

@michael-hawker
Copy link
Member

It's this stuff here:

https://github.com/CommunityToolkit/Tooling-Windows-Submodule/blob/f841534f3f0e213603e94de00f8286ceac3d7a6b/CommunityToolkit.App.Shared/Controls/TitleBar/NativeMethods.cs#L13-L24

It's in a file called NativeMethods but not a class called NativeMethods it needs to be extracted. Eventually, we should just use CS/Win32 for this, but not sure how easy that'd be to setup in our build at the moment.

@michael-hawker michael-hawker mentioned this pull request Jul 25, 2023
Draft
michael-hawker
michael-hawker approved these changes Jul 25, 2023
View reviewed changes
Copy link
Member

@michael-hawker michael-hawker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, need this so that we can get a clean build in the tooling matrix PR

@michael-hawker michael-hawker mentioned this pull request Jul 25, 2023
Merged
@Arlodotexe Arlodotexe enabled auto-merge (squash) July 25, 2023 22:24
@michael-hawker michael-hawker mentioned this pull request Jul 25, 2023
Merged
@Arlodotexe Arlodotexe merged commit 3c888a3 into main Jul 25, 2023
7 checks passed
@delete-merged-branch delete-merged-branch bot deleted the tooling/update branch July 25, 2023 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-hawker michael-hawker michael-hawker approved these changes

@niels9001 niels9001 Awaiting requested review from niels9001

Assignees

@Arlodotexe Arlodotexe

Labels
bug Something isn't working dev loop ➰ regression What was working is now broke
Projects
Toolkit 8.x
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Arlodotexe @michael-hawker