Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AdvancedCollectionView: Use generic arguments if possible to get type of elements in list #182

Merged
merged 2 commits into from
Aug 23, 2023
Merged

AdvancedCollectionView: Use generic arguments if possible to get type of elements in list #182

merged 2 commits into from
Aug 23, 2023

Conversation

Arlodotexe
Copy link
Member

Fixes #78

Carryover from #80

@Arlodotexe Arlodotexe mentioned this pull request Aug 23, 2023
Closed
@Arlodotexe Arlodotexe enabled auto-merge (rebase) August 23, 2023 01:27
@michael-hawker michael-hawker force-pushed the fix/advancedcollectionview/generics-in-list-source branch from b8c0e4a to a229462 Compare August 23, 2023 06:28
michael-hawker
michael-hawker approved these changes Aug 23, 2023
View reviewed changes
Copy link
Member

@michael-hawker michael-hawker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test is simple, but exercises the new code. We could improve it a bit in the future with validating more of the behavior with Assert. Will get the code change in now and can revisit more later with other ACV improvements for other issues.

@Arlodotexe Arlodotexe merged commit 688b17d into main Aug 23, 2023
9 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix/advancedcollectionview/generics-in-list-source branch August 23, 2023 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-hawker michael-hawker michael-hawker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@Arlodotexe @michael-hawker @lhak