Updates build.yml trigger to automatically start workflow when a release branch is created #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ase branch is created
|
Not sure why the CI failed here, some 400 error on artifact upload. Re-running. |
Arlodotexe
approved these changes
Aug 28, 2023
|
Thought for a second I had to look into the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our release process then just becomes create a branch off main named
rel/major.minor.YYMMDD[-previewtag]like I did with 8.0.230823-rc.This will then make it auto-trigger the workflow and wait to push to NuGet.org when an authorized maintainer signs-off on that step. (I had to manually start the workflow on the new branch for our first release.)
Only thing we need to do for minor/major versions is to update the directory props files ahead of that branch creation, which we should probably do along with whatever larger change we're planning to do or whatnot.