Add sample/tests for FrameworkElementExtensions.Ancestor/Type #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Extensions.RelativeAncestor to FrameworkElement over DependencyObject Code scoped to FrameworkElement in callback, so doesn't work with just DependencyObject as-is.
|
Should investigate fixing CommunityToolkit/WindowsCommunityToolkit#4322 |
Fixes malaligned namespaces in tests.
|
Added basic test case, going to look at testing unloading scenario and see what happens. Thinking to fix the memory reference though may need the |
Closed
11 tasks
2 tasks
8 tasks
|
Hmm, failed at Failed |
michael-hawker
commented
Jul 5, 2023
components/Extensions/tests/Element/FrameworkElementExtensionsTests.RelativeAncestor.cs
Show resolved
Hide resolved
Arlodotexe
approved these changes
Jul 11, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new sample for this extension, works on UWP and WASDK. Didn't test WASM yet.
Maybe should try adding a test too...
Not sure if any other info should be provided here, thoughts @Arlodotexe? These could be good things to start shoring up or finishing the docs/sample migration of.
Also fixes #106
Adds tests for #107
Supersedes CommunityToolkit/WindowsCommunityToolkit#4322