Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HeaderedControls #109

Merged
merged 13 commits into from
Jul 10, 2023
Merged

HeaderedControls #109

merged 13 commits into from
Jul 10, 2023

Conversation

niels9001
Copy link
Collaborator

Copy link
Member

@michael-hawker michael-hawker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for bringing these over! Agree we should just have a single package for all these 'light-weight' helpers. Wonder if we're missing any at this point... 😋

Couple of small comments.

@niels9001
Copy link
Collaborator Author

@michael-hawker I think I addressed your feedback :-). Added the same tests that are normally generated by default.

Copy link
Member

@michael-hawker michael-hawker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple minor fixes needed, otherwise looks good. I'll push a fix for the WUX/MUXC issue though quick as I tested locally.

@michael-hawker
Copy link
Member

Thanks @Arlodotexe for fixing that!

@michael-hawker michael-hawker merged commit bea1c71 into main Jul 10, 2023
7 checks passed
@delete-merged-branch delete-merged-branch bot deleted the niels9001/headeredcontrols branch July 10, 2023 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants