Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ported source code for CommunityToolkit.WinUI.Media #113

Merged
merged 15 commits into from
Jul 13, 2023
Merged

Ported source code for CommunityToolkit.WinUI.Media #113

merged 15 commits into from
Jul 13, 2023

Conversation

Arlodotexe
Copy link
Member

@Arlodotexe Arlodotexe commented Jul 6, 2023 •
edited
Loading

This PR brings over the source code for CommunityToolkit.WinUI.Media for #35.

This includes:

  • Support for both UWP and WinAppSDK where possible
  • Added nullable type annotations.
  • A minor correction to nullable annotations in the Animations package.
  • A new internal ArgumentNullExceptionExtensions polyfill (courtesy of @Sergio0694) to enable clean argument validation.

This does not include:

  • Any samples, tests or documentation. These will be added in a future PR.
  • Backdrop brush functionality on WinAppSDK (unsupported)
  • Support for any Uno Platform. The required Win2d and Composition APIs are not available.

@Arlodotexe Arlodotexe added the enhancement New feature or request label Jul 6, 2023
michael-hawker
michael-hawker reviewed Jul 6, 2023
View reviewed changes
Copy link
Member

@michael-hawker michael-hawker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Arlo, were there any other infrastructure or changes made with the sync from @Sergio0694?

components/Media/src/Brushes/RadialGradientBrush.cs Outdated Show resolved Hide resolved
@Arlodotexe Arlodotexe mentioned this pull request Jul 6, 2023
Merged
@Arlodotexe
Copy link
Member Author

Arlodotexe commented Jul 7, 2023 •
edited
Loading

Thanks Arlo, were there any other infrastructure or changes made with the sync from @Sergio0694?

Most of the differences are in WASDK support, e.g. no Backdrop brushes or APIs. Changes all listed above.

@michael-hawker michael-hawker mentioned this pull request Jul 10, 2023
Merged
@Arlodotexe Arlodotexe enabled auto-merge (rebase) July 11, 2023 00:47
@michael-hawker
Copy link
Member

@Arlodotexe looks like Win2D doesn't copy on the Any CPU option:

6>C:\Users\.nuget\packages\microsoft.graphics.win2d\1.0.5.1\build\net5.0-windows10.0.17763.0\Microsoft.Graphics.Win2D.targets(24,5): warning : Microsoft.Graphics.Canvas.dll could not be copied because the AnyCPU platform is being used. Please specify a specific platform to copy this file.
6>    1 Warning(s)

@michael-hawker
Copy link
Member

Also getting this trying to run after x64 WASDK on the component solution:

image

@michael-hawker
Copy link
Member

Ah, maybe because there's literally no samples/docs?

@michael-hawker
Copy link
Member

michael-hawker commented Jul 13, 2023 •
edited
Loading

Looks like new files have issues with CI and need update from main.

@Arlodotexe Arlodotexe mentioned this pull request Jul 13, 2023
Merged
auto-merge was automatically disabled July 13, 2023 20:44

Rebase failed

@michael-hawker michael-hawker merged commit 90e6909 into main Jul 13, 2023
7 checks passed
@delete-merged-branch delete-merged-branch bot deleted the port/media branch July 13, 2023 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-hawker michael-hawker michael-hawker approved these changes

@niels9001 niels9001 Awaiting requested review from niels9001

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Arlodotexe @michael-hawker