Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance: Add spacing properties for DockPanel #346

Merged
merged 7 commits into from
Mar 4, 2024
Merged

Enhance: Add spacing properties for DockPanel #346

merged 7 commits into from
Mar 4, 2024

Conversation

Poker-sang
Copy link
Contributor

Fixes

#293

PR Type

What kind of change does this PR introduce?

Enhance: Add spacing properties for DockPanel

HorizontalSpacing and VerticalSpacing

What is the current behavior?

No HorizontalSpacing and VerticalSpacing property

What is the new behavior?

Has HorizontalSpacing and VerticalSpacing property

PR Checklist

Please check if your PR fulfills the following requirements:

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • Tested code with current supported SDKs
  • New component
    • Documentation has been added
    • Sample in sample app has been added
    • Analyzers are passing for documentation and samples
    • Icon has been created (if new sample) following the Thumbnail Style Guide and templates
  • Tests for the changes have been added (if applicable)
  • Header has been added to all new source files
  • Contains NO breaking changes

Other information

HorizontalSpacing="5" VerticalSpacing="5"

image

@michael-hawker michael-hawker added this to the 8.1 milestone Feb 27, 2024
@michael-hawker michael-hawker added the enhancement New feature or request label Feb 27, 2024
@michael-hawker
Copy link
Member

Thanks @Poker-sang, great idea! Think the naming of these makes sense, aligns with our existing WrapPanel ones.

Not sure why the linux build is tripping up on the condensed syntax. Believe @Arlodotexe has updated and fixed the Uno-check conflict, but think that's in the #328 PR, so we may need to wait for that one to be merged (should be soon).

@Arlodotexe
Copy link
Member

Noting the error message in the WinUI2 CI build for 78f0dd7:

2024-03-01T03:03:57.0643508Z        "C:\a\Windows\Windows\CommunityToolkit.AllComponents.sln" (default target) (1:2) ->
2024-03-01T03:03:57.0644112Z        "C:\a\Windows\Windows\components\Primitives\src\CommunityToolkit.WinUI.Controls.Primitives.csproj" (default target) (25:43) ->
2024-03-01T03:03:57.0644668Z        "C:\a\Windows\Windows\components\Primitives\src\CommunityToolkit.WinUI.Controls.Primitives.csproj" (Build target) (25:49) ->
2024-03-01T03:03:57.0644807Z        (CoreCompile target) -> 
2024-03-01T03:03:57.0646318Z          C:\a\Windows\Windows\components\Primitives\src\DockPanel\DockPanel.cs(85,34): error CS0518: Predefined type 'System.Index' is not defined or imported [C:\a\Windows\Windows\components\Primitives\src\CommunityToolkit.WinUI.Controls.Primitives.csproj::TargetFramework=uap10.0.17763]
2024-03-01T03:03:57.0647687Z          C:\a\Windows\Windows\components\Primitives\src\DockPanel\DockPanel.cs(85,34): error CS0656: Missing compiler required member 'System.Index..ctor' [C:\a\Windows\Windows\components\Primitives\src\CommunityToolkit.WinUI.Controls.Primitives.csproj::TargetFramework=uap10.0.17763]
2024-03-01T03:03:57.0647704Z 
2024-03-01T03:03:57.0647785Z     7 Warning(s)
2024-03-01T03:03:57.0647870Z     2 Error(s)
2024-03-01T03:03:57.0647875Z 
2024-03-01T03:03:57.0647990Z Time Elapsed 01:16:21.06
2024-03-01T03:03:57.0652749Z ##[error]Process completed with exit code 1.

@Poker-sang
Copy link
Contributor Author

Noting the error message in the WinUI2 CI build for 78f0dd7:

Thanks for the heads up, I hadn't noticed it.

Arlodotexe
Arlodotexe approved these changes Mar 1, 2024
View reviewed changes
Copy link
Member

@Arlodotexe Arlodotexe left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Locally tested, looks good! Added the new properties to the sample as well 👍

@Arlodotexe Arlodotexe enabled auto-merge (rebase) March 1, 2024 22:52
@Arlodotexe Arlodotexe merged commit b8088df into CommunityToolkit:main Mar 4, 2024
9 checks passed
@Poker-sang Poker-sang deleted the Poker-sang/DockPanel branch March 4, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arlodotexe Arlodotexe Arlodotexe approved these changes

@michael-hawker michael-hawker michael-hawker left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Toolkit 8.x
Status: ✅ Done
Milestone
8.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Poker-sang @michael-hawker @Arlodotexe