Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add overlay to ImageCropper #364

Merged
merged 3 commits into from
Mar 25, 2024
Merged

Conversation

shatyuka
Copy link
Contributor

@shatyuka shatyuka commented Mar 9, 2024

Fixes

#363

Add an overlay to the inner crop area to show something like placeholders.

PR Type

What kind of change does this PR introduce?

Add new feature to ImageCropper

What is the current behavior?

No overlay.

What is the new behavior?

Add a overlay layer over mask layer plus with a brush property Overlay.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • Tested code with current supported SDKs
  • Tests for the changes have been added (if applicable)
  • Contains NO breaking changes

Other information

Preview:
baee4f05707cec3c

@shatyuka
Copy link
Contributor Author

shatyuka commented Mar 9, 2024

@dotnet-policy-service agree

Copy link
Member

@Arlodotexe Arlodotexe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and combed through the code to ensure we're only adding what's necessary.

I've also added a sample for using the overlay:
image

@Arlodotexe Arlodotexe added this to the 8.1 milestone Mar 22, 2024
@Arlodotexe Arlodotexe merged commit b0abb7c into CommunityToolkit:main Mar 25, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants